feat(smartphone): add model_3d/body schema fields + fix image_url doc bug (ADR-015) - #83
Merged
Merged
Conversation
…example (ADR-015)
Seungpyo1007
force-pushed
the
feat/smartphone-3d-schema-fields
branch
from
September 24, 2026 14:53
8cf9556 to
bc32781
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TechPicks (the reference-consumer app) requested
.glb3D model support for its device viewer. Root-caused their "all image_url 404" report along the way: SPEC.md's own response example showed a fictionalcdn.jsdelivr.net/gh/GetTechAPI/images/...path that repo never existed — TechPicks built against that doc example instead of real data (realimage_urlhotlinks the original host, e.g. gsmarena.com, and works fine).Smartphone.model_3d: dict | NoneandSmartphone.body: dict | None— schema fields only, all-null for now. Actual.glbfile sourcing is out of scope (no free/licensed 3D model source identified yet for hundreds of devices) and deferred to a separate track.image_urlexample in SPEC.md §6.4 and appendix C to a real host instead of the fictional CDN path.Test plan
pytest tests/ -k smartphone— 54 passedpytest tests/(full suite) — all passed