[gatisb]

Problem

On Linux and macOS, Uri.TryCreate(url, UriKind.Absolute, out _) accepts a rooted path such as /page?id=1 as an implicit file URI (file:///page%3Fid=1). So IsAbsoluteUrl("/page") returns true there, while it returns false on Windows.

The existing IsAbsoluteUrl_with_relative_url_is_false cases (/mypage, /mypage/anotherpage) already expect false. They only pass because CI runs on windows-latest.

Downstream impact: Geta.Optimizely.Extensions' RemoveHost(), which every GetFriendlyUrl() goes through, does if (url.IsAbsoluteUrl()) return new Uri(url).PathAndQuery;. On Linux this turns a relative URL with a query string into one with %3F in its path. For example, the Optimizely On-Page Editing URL /…,,123?epieditmode=true becomes /…,,123%3Fepieditmode=true, and the CMS returns HTTP 500. We hit this on a CMS 12 site hosted on Linux App Service.

RemoveHost delegates to this method, so a Geta.Net.Extensions patch fixes both Geta.Optimizely.Extensions 2.x (CMS 12) and 3.x (CMS 13) without a new release of that package.

Change

• IsAbsoluteUrl now returns false for server-relative paths: a single leading / that Uri parsed as a file URI. On Windows this changes nothing, because TryCreate already rejects such paths.
• //host/path (UNC or network-path reference) and explicit file: URIs behave as before.
• IsRelativeUrl needs no change. UriKind.Relative treats /page as relative on every OS.
• Tests: added cases for /, /mypage?query=1 and an edit-mode-style URL, plus checks that https://…?query=1 and file:///… stay absolute.
• CI (separate commits):
  • A Test (Linux) job on ubuntu-latest, installing .NET 6 via setup-dotnet for the net6.0 test project. The existing tests would have caught this bug. Drop the commit if you'd rather not have it.
  • The Windows Build job first failed in "Set up job", because GitHub no longer serves actions/cache@v1.
    • With the actions updated, it failed next in the SonarCloud step. SONAR_TOKEN (set in 2022) no longer authenticates, and the Geta_geta-dotnet-extensions project is gone from the geta SonarCloud organization.
    • So the job now just builds and runs the tests on Windows. It installs the .NET 6 runtime that windows-latest no longer ships.
    • The stale Quality Gate badge is removed from the README.
  • Both jobs use the current Node 24 majors (actions/checkout@v7, actions/setup-dotnet@v6).
  • release.yml had the same gap: its Test step would have failed on a tag build without the .NET 6 runtime. It now installs .NET 6 and uses actions/checkout@v7.
    • It only runs on tag pushes, so it's untested in CI.
    • Its build, test and pack commands pass locally with the current SDK: 67/67 tests, and Geta.Net.Extensions.<version>.nupkg is created.
• CHANGELOG: added a [3.0.2] entry. I suggest releasing this as v3.0.2.

Testing

• dotnet test on Windows: 67/67 pass. The new relative-path cases also pass on Windows without the fix, because only Unix is affected.
• The Test (Linux) job covers the Unix behaviour.

Notes

• SonarCloud: the SONAR_TOKEN repository secret is now unused, so a repo admin can delete it.
  • To bring the analysis back: re-import the project in SonarCloud, add a fresh token, and restore the analysis steps.
  • Commit 9316ffe has an updated version of those steps (JDK 17, sonar.token) that got as far as authentication.
• Noticed but not changed: IsRelativeUrl_with_invalid_url_is_false calls IsAbsoluteUrl() instead of IsRelativeUrl(). Note that "".IsRelativeUrl() actually returns true.

🤖 Generated with Claude Code