Repository navigation
The Allegro export escapes net names, and works without a GUI prompt - #161
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
…ut a GUI Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
Contributor
|
Owner
Author
/prr round 1Fixing:
FYI, not fixing:
None of this is runnable here; no test runs the SKILL script. |
…y string field fprintf no longer reads output lines as its format, so % needs no doubling. jsonEscape now also covers metadata, board text, pin numbers, and the component table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
Owner
Author
/prr round 2 (56ded7c..531be4d)Fixing:
FYI, not fixing:
None of this is runnable here; no test runs the SKILL script. |
Both were still written raw after jsonEscape was applied to the other string fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160.
exportJson.ilwrote net names into the JSON as they are. A net name with"or\made the file invalid JSON.jsonEscapeescapes\first, then". It also doubles%, becausewriteJsonFilepasses each line tofprintfas the format string. The component table already doubles%for the same reason.axlUIPromptreturns nil for rev and company when run without a GUI. Both now fall back to"", soaddMetadatadoes not fail.Testing
npm run test:apipasses.🤖 Generated with Claude Code
https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK