Repository navigation
Refuse directory-symlink loops to prevent unbounded recursion in addF… - #105
Merged
Merged
Conversation
GrapeGreen
approved these changes
Sep 16, 2026
addFilesRecursively() previously traversed directory structures using fs.statSync(), which dereferences symbolic links. If a directory symlink loop is present in the static directory (e.g. 'ln -s . loop'), the recursive traversal runs indefinitely until Node.js throws an ELOOP error, crashing the build process (CWE-674). Use fs.lstatSync() to detect symbolic links and refuse to follow them, preventing infinite recursion and build crashes. Bug: https://b.corp.google.com/issues/530773570
shangl
force-pushed
the
fix-symlink-loop
branch
from
September 16, 2026 15:09
3742a4e to
08f8183
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent recursion loops from directory symlinks
addFilesRecursively() previously traversed directory structures using
fs.statSync(), which dereferences symbolic links. If a directory
symlink loop is present in the static directory (e.g. 'ln -s . loop'),
the recursive traversal runs indefinitely until Node.js throws an
ELOOP error, crashing the build process (CWE-674).
Use fs.lstatSync() to detect symbolic links and refuse to follow them,
preventing infinite recursion and build crashes.
Bug: b/530773570