[derrickaw]

Problem: In #4450, dependabot was trying to upgrade hadoop client runtime to 3.5, but that would drift away from the parent one.
Fix: Use parent pom hadoop version.

[derrickaw]

/gemini review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.84%. Comparing base (f4ba1e9) to head (e602587).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #4460      +/-   ##
============================================
- Coverage     56.85%   56.84%   -0.02%     
+ Complexity     8087     8083       -4     
============================================
  Files          1164     1164              
  Lines         74114    74114              
  Branches       8735     8735              
============================================
- Hits          42138    42130       -8     
- Misses        29174    29181       +7     
- Partials       2802     2803       +1     

Components	Coverage Δ
spanner-templates	83.69% <ø> (-0.01%)	⬇️
spanner-import-export	72.17% <ø> (-0.03%)	⬇️
spanner-live-forward-migration	86.91% <ø> (-0.02%)	⬇️
spanner-live-reverse-replication	79.20% <ø> (-0.02%)	⬇️
spanner-bulk-migration	87.87% <ø> (-0.01%)	⬇️
gcs-spanner-dv	85.70% <ø> (-0.02%)	⬇️
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gemini-code-assist]

Code Review

This pull request updates the hadoop-client-runtime dependency in it/iceberg/pom.xml to use the ${hadoop.version} property instead of a hardcoded version. There are no review comments, and I have no feedback to provide.

[derrickaw]

wait until #4503 is merged to fix the flaky java tests

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request ensures consistency in dependency management by aligning the Hadoop client runtime version with the parent POM. This change prevents version drift and simplifies maintenance when updating dependencies across the project.

Highlights

• Dependency Version Alignment: Updated the hadoop-client-runtime dependency in it/iceberg/pom.xml to reference the parent POM's version property instead of a hardcoded version.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the Maven configuration in it/iceberg/pom.xml by replacing the hardcoded version 3.4.0 for the hadoop-client-runtime dependency with the property placeholder ${hadoop.version}. There are no review comments, and I have no further feedback to provide.