Repository navigation
Add Oracle Reverse Datatype ITs - #4490
Open
dhwanilpatel wants to merge 2 commits into
Open
dhwanilpatel wants to merge 2 commits into
dhwanilpatel wants to merge 2 commits into
Conversation
dhwanilpatel
force-pushed
the
reverse_oracle_datatype_it
branch
from
October 27, 2026 09:55
e6468b8 to
0015379
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4490 +/- ##
=============================================
+ Coverage 33.90% 63.33% +29.42%
- Complexity 509 3077 +2568
=============================================
Files 215 582 +367
Lines 13251 34356 +21105
Branches 1335 3917 +2582
=============================================
+ Hits 4493 21760 +17267
- Misses 8388 11497 +3109
- Partials 370 1099 +729
🚀 New features to boost your workflow:
|
dhwanilpatel
marked this pull request as ready for review
October 27, 2026 10:53
dhwanilpatel
requested review from
bharadwaj-aditya,
manitgupta and
varunsv-creator
October 27, 2026 10:53
Contributor
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
bharadwaj-aditya
left a comment
bharadwaj-aditya
left a comment
Contributor
There was a problem hiding this comment.
Reviewed PR #4490 — added inline comments on Scenario D validation / DLQ retries, test helper deduplication, and PostgreSQL dialect table parity.
| private static Object readValue(ResultSet rs, Compare mode) throws Exception { | ||
| Object v; | ||
| switch (mode) { | ||
| case NUMBER: |
Contributor
There was a problem hiding this comment.
how are the other types compared ? Same comment on next method.
Contributor
Author
There was a problem hiding this comment.
We read the various types in these specific formats for comparing. For e.g. we are reading datatime as string and compare.
private static final String DATE_TEXT = "TO_CHAR(%s, 'YYYY-MM-DD HH24:MI:SS')";
private static final String TIMESTAMP_TEXT = "TO_CHAR(%s, 'YYYY-MM-DD HH24:MI:SS.FF6')";
private static final String TIMESTAMP_UTC_TEXT =
"TO_CHAR(SYS_EXTRACT_UTC(%s), 'YYYY-MM-DD HH24:MI:SS.FF6')";
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add oracle reverse datatype ITs.