feat(genai): migrate ImageGenWithText to gemini-2.5-flash-image - #10335
Draft
Kef131 wants to merge 2 commits into
Draft
feat(genai): migrate ImageGenWithText to gemini-2.5-flash-image#10335Kef131 wants to merge 2 commits into
ImageGenWithText to gemini-2.5-flash-image#10335Kef131 wants to merge 2 commits into
Conversation
- Update ImageGenWithText to use client.models.generateContent with gemini-2.5-flash-image - Update ImageGenerationIT with configurable bucket, safe cleanup, and testImageGenWithText validation - Temporarily ignore remaining deprecated Imagen capability tests pending migration
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the image generation sample and its integration tests from using the deprecated Imagen model to the Gemini model (gemini-2.5-flash-image) via the generateContent API. It also updates the integration tests to handle GCS cleanup errors gracefully and temporarily ignores tests associated with deprecated Imagen models. The reviewer suggested using the %d format specifier instead of %s when printing the image byte length to ensure proper type-safe formatting.
…hText.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
b/549909475
ImageGenWithText.javafrom deprecated Imagen (imagen-4.0-generate-001viaclient.models.generateImages) togemini-2.5-flash-imageusingclient.models.generateContentwithresponseModalities("TEXT", "IMAGE").ImageGenerationIT.javato support configurableBUCKET_NAME, add safe error handling in@AfterClass cleanup(), and validatetestImageGenWithTextagainstgemini-2.5-flash-image.@Ignorepending multimodal migration in follow-up PR.Checklist
Testing
mvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory onlyCompliance & Style
pom.xmlparent set to latestshared-configurationPost-Approval Actions