Repository navigation
Conversation
trusted-contributions-gcf
Bot
added
the
kokoro:force-run
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the base image in Dockerfile.custom from PHP 8.3 to PHP 8.5. However, the reviewer pointed out that the official PHP 8.5 image is not yet available on Docker Hub, which will cause the build to fail, and suggested using PHP 8.4 instead.
| # Use the official PHP 8.3 Apache image for App Engine Flexible custom runtimes. | ||
| # https://hub.docker.com/_/php | ||
| FROM php:8.3-apache | ||
| FROM php:8.5-apache |
There was a problem hiding this comment.
The official PHP 8.5 image is not yet released or available on Docker Hub. Attempting to build this Dockerfile will fail because the image php:8.5-apache does not exist. Please use a valid, existing PHP version such as php:8.4-apache.
FROM php:8.4-apache
bshaffer
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
8.3-apache→8.5-apacheConfiguration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.