Repository navigation
Hide session resets in the Overview's Events by default - #28
Conversation
A 5-hour session resets several times a day, so its rows buried the weekly resets and everything else in the Events list. Resets of a Window under a day are now hidden unless "Show session resets" is on, a switch next to the Events heading that's off by default and remembered. A reset whose Window length isn't known stays visible.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the primary change: hiding session reset events in the Overview Events list by default. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes match the intended behavior, with relevant test coverage and no unresolved blocking findings.
No open issues 🎉
What changed in this PR
Reduces noise in the Overview’s Events list by hiding short-window resets by default.
Changes:
- Filters resets under one day while preserving unknown-window resets and other events.
- Adds a persistent “Show session resets” switch and updates the empty-state message.
- Adds tests covering filtering and preserved events.
| File | Description |
|---|---|
| Tests/BarUICoreTests/OverviewEventsTests.swift | Tests short-window filtering and event preservation. |
| Sources/BarUICore/OverviewEvent.swift | Adds reset window metadata and filtering. |
| Sources/BarUI/EventsSection.swift | Adds the persistent switch and filtered display. |
Review effort: Balanced
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 175b39b410
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
A 5-hour session resets several times a day, so the Overview's Events list was mostly "Session (5h) reset" rows. They buried the weekly resets and everything else.
OverviewEventcarries the reset Limit's Window length.hidingShortWindowResetsdrops resets of a Window under a day.@AppStorage. When everything in range is hidden, the empty state says that session resets are hidden.Test plan
swift test: 345 tests passScreenshots
Before: the Events list is mostly session resets.
After, on the v0.9 release: only the weekly resets, with the switch off.