Repository navigation
Don't use install location for RelWithDebInfo - #4212
Open
ryneeverett wants to merge 1 commit into
Open
ryneeverett wants to merge 1 commit into
ryneeverett wants to merge 1 commit into
Conversation
The recommended CMAKE_BUILD_TYPE in development.md is RelWithDebInfo but if this is used the tests then fail with "Could not find file in CWD, directory of config file or search paths 'default.theme'." I believe this was an oversight in GothenburgBitFactory#4175. Also fix some typos.
djmitche
approved these changes
Oct 24, 2026
| if (CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo" OR CMAKE_BUILD_TYPE STREQUAL "Debug") | ||
| target_compile_definitions(task PRIVATE | ||
| -DTASK_TEST_RCDIR="${CMAKE_SOURCE_DIR}/doc/rc" | ||
| ) |
Member
There was a problem hiding this comment.
The amount of extra work around this hack to get tests working is kind of a bummer :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recommended CMAKE_BUILD_TYPE in development.md is RelWithDebInfo but if this is used the tests then fail with "Could not find file in CWD, directory of config file or search paths 'default.theme'." I believe this was an oversight in #4175.
Also fix some typos.