Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for copying multiple cached stories or covers at once into an issue revision, including UI updates for multiple selection, confirmation templates, and comprehensive unit tests. Feedback on the changes suggests correcting the indentation of the new _parse_selection function to follow PEP 8, improving the robustness of checkbox boolean checks by verifying key presence in request.POST instead of using .get(), and handling cases where multiple_selection might be explicitly set to None in session data.
- Reformat _parse_selection to use standard 4-space PEP 8 indentation instead of 8 spaces. - Replace request.POST.get(key, False) with 'key' in request.POST for copy_credit_info/copy_characters checkbox handling, since unchecked checkboxes are omitted from POST data. - Make the multiple_selection check explicitly handle None in session data before falling back to the return-based default, matching the GET branch logic.
Contributor
Author
|
This PR is superseded by #767. The changes have been incorporated into the newer PR, which should be reviewed and merged instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change affects the Online Indexer Copy Sequence workflow.
Start from an issue changeset edit page, then select Copy Sequence.
The change is implemented in the session-based object selection screen,
select_object, used to select stories from the data cache.Summary
Clear Objectsand multiple-object removal actions.The implementation reuses the existing session-based selection flow and wraps the multiple-copy operation in a Django transaction.
Validation