Skip to content

Fix Italian catalog terminology and add gettext to development image - #765

Open
ProfNardi wants to merge 1 commit into
GrandComicsDatabase:betafrom
ProfNardi:fix/italian-catalog-gettext
Open

ProfNardi wants to merge 1 commit into
GrandComicsDatabase:betafrom
ProfNardi:fix/italian-catalog-gettext

Conversation

@ProfNardi

Copy link
Copy Markdown
Contributor

Summary

Improved the Italian translations in the comics/editorial context and enabled translation compilation in the development container.

Changes

  • Added gettext to Dockerfile.dev, providing the msgfmt utility required by Django's compilemessages.

  • Corrected Italian terminology:

    • Clarified collection actions and labels for updated issues.
  • Updated the Italian and Portuguese catalog headers; Portuguese message translations remain unchanged.

Compatibility

  • Preserved existing template message keys and placeholders.
  • Did not modify HTML templates or generate .mo files.
  • Left the existing template-based pluralization unchanged.

Suggestions

  • Consider updating compose.yaml to automate the compilation of translation catalogs when starting the development container.

Validation

  • Italian and Portuguese catalogs compiled successfully with gettext installed in the development container.
  • git diff --check passed.
  • Docker image rebuild was not tested.

Refine comics and collection terminology, restore missing homepage content, and retain message keys compatible with existing templates. Update Italian and Portuguese catalog headers and install GNU gettext for compilemessages.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the gettext package to the development Dockerfile and updates the Italian and Portuguese translation files (django.po). Specifically, it refines several Italian translation strings for better accuracy and updates the metadata headers for both locales. There are no review comments, so I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant