Skip to content

Reintroduce improved logic for mesh interior region fill determination - #4464

Merged
Keavon merged 4 commits into
masterfrom
derived-face-fill
Aug 19, 2026
Merged

Reintroduce improved logic for mesh interior region fill determination#4464
Keavon merged 4 commits into
masterfrom
derived-face-fill

Conversation

@Keavon

@Keavon Keavon commented Aug 19, 2026

Copy link
Copy Markdown
Member

As removed in #4463, now reintroduced by acting based on the topology of the mesh geometry itself instead of an inconsistently used boolean flag taking the form of the RegionDomain data.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread node-graph/libraries/vector-types/src/vector/vector_attributes.rs Outdated
Comment thread node-graph/libraries/vector-types/src/vector/vector_attributes.rs Outdated
Comment thread node-graph/nodes/vector/src/vector_modification_nodes.rs
@github-actions

Copy link
Copy Markdown
Performance Benchmark Results

🔧 Graph Compilation

compile_demo_art_gungraun::compile_group::compile_to_proto with_setup_0:(load_from_name(isometric-fountain))
Instructions: 32,610,805 (master) → 32,613,951 (HEAD) : $$\color{red}+0.01\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.10%
D1mr                     465,840|    465,337          -0.11%
D1mw                     133,210|    133,097          -0.08%
DLmr                      36,724|     36,708          -0.04%
DLmw                      58,820|     58,814          -0.01%
Dr                     7,967,980|  7,968,078          +0.00%
Dw                     5,547,165|  5,547,018          -0.00%
EstimatedCycles       51,622,474| 51,609,839          -0.02%
I1MissRate                     0|          0          -6.10%
I1mr                      51,736|     48,584          -6.09%
ILmr                         902|        902          +0.00%
Ir                    32,610,805| 32,613,951          +0.01%
L1HitRate                     99|         99          +0.01%
L1hits                45,475,164| 45,482,029          +0.02%
LLHitRate                      1|          1          -0.68%
LLMissRate                     0|          0          -0.03%
LLdMissRate                    1|          1          -0.02%
LLhits                   554,340|    550,594          -0.68%
LLiMissRate                    0|          0          -0.01%
RamHitRate                     0|          0          -0.03%
RamHits                   96,446|     96,424          -0.02%
TotalRW               46,125,950| 46,129,047          +0.01%

compile_demo_art_gungraun::compile_group::compile_to_proto with_setup_1:(load_from_name(painted-dreams))
Instructions: 17,352,748 (master) → 17,353,443 (HEAD) : $$\color{red}+0.00\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.04%
D1mr                     238,748|    238,718          -0.01%
D1mw                      71,568|     71,485          -0.12%
DLmr                       1,149|      1,121          -2.44%
DLmw                      23,113|     23,076          -0.16%
Dr                     4,239,494|  4,239,585          +0.00%
Dw                     2,946,087|  2,946,115          +0.00%
EstimatedCycles       26,622,297| 26,615,405          -0.03%
I1MissRate                     0|          0          -5.59%
I1mr                      23,191|     21,895          -5.59%
ILmr                         736|        732          -0.54%
Ir                    17,352,748| 17,353,443          +0.00%
L1HitRate                     99|         99          +0.01%
L1hits                24,204,822| 24,207,045          +0.01%
LLHitRate                      1|          1          -0.44%
LLMissRate                     0|          0          -0.28%
LLdMissRate                    0|          0          -0.27%
LLhits                   308,509|    307,169          -0.43%
LLiMissRate                    0|          0          -0.55%
RamHitRate                     0|          0          -0.28%
RamHits                   24,998|     24,929          -0.28%
TotalRW               24,538,329| 24,539,143          +0.00%

compile_demo_art_gungraun::compile_group::compile_to_proto with_setup_2:(load_from_name(procedural-string-lights))
Instructions: 3,476,791 (master) → 3,476,719 (HEAD) : $$\color{lime}-0.00\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          +0.06%
D1mr                      44,237|     44,273          +0.08%
D1mw                      14,479|     14,480          +0.01%
DLmr                          19|         19          +0.00%
DLmw                       3,165|      3,164          -0.03%
Dr                       849,692|    849,687          -0.00%
Dw                       590,284|    590,294          +0.00%
EstimatedCycles        5,290,801|  5,289,780          -0.02%
I1MissRate                     0|          0          -4.85%
I1mr                       5,520|      5,252          -4.86%
ILmr                         719|        719          +0.00%
Ir                     3,476,791|  3,476,719          -0.00%
L1HitRate                     99|         99          +0.00%
L1hits                 4,852,531|  4,852,695          +0.00%
LLHitRate                      1|          1          -0.38%
LLMissRate                     0|          0          -0.02%
LLdMissRate                    0|          0          -0.03%
LLhits                    60,333|     60,103          -0.38%
LLiMissRate                    0|          0          +0.00%
RamHitRate                     0|          0          -0.02%
RamHits                    3,903|      3,902          -0.03%
TotalRW                4,916,767|  4,916,700          -0.00%

compile_demo_art_gungraun::compile_group::compile_to_proto with_setup_3:(load_from_name(parametric-dunescape))
Instructions: 12,695,576 (master) → 12,696,760 (HEAD) : $$\color{red}+0.01\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.10%
D1mr                     173,567|    173,356          -0.12%
D1mw                      59,887|     59,875          -0.02%
DLmr                          46|         37         -19.57%
DLmw                      16,299|     16,307          +0.05%
Dr                     3,092,380|  3,092,486          +0.00%
Dw                     2,168,381|  2,168,339          -0.00%
EstimatedCycles       19,458,357| 19,456,929          -0.01%
I1MissRate                     0|          0          -3.18%
I1mr                      13,111|     12,695          -3.17%
ILmr                         847|        844          -0.35%
Ir                    12,695,576| 12,696,760          +0.01%
L1HitRate                     99|         99          +0.00%
L1hits                17,709,772| 17,711,659          +0.01%
LLHitRate                      1|          1          -0.28%
LLMissRate                     0|          0          -0.03%
LLdMissRate                    0|          0          -0.01%
LLhits                   229,373|    228,738          -0.28%
LLiMissRate                    0|          0          -0.36%
RamHitRate                     0|          0          -0.03%
RamHits                   17,192|     17,188          -0.02%
TotalRW               17,956,337| 17,957,585          +0.01%

compile_demo_art_gungraun::compile_group::compile_to_proto with_setup_4:(load_from_name(red-dress))
Instructions: 36,955,313 (master) → 36,951,019 (HEAD) : $$\color{lime}-0.01\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.06%
D1mr                     535,361|    535,118          -0.05%
D1mw                     151,650|    151,507          -0.09%
DLmr                      47,127|     47,195          +0.14%
DLmw                      77,721|     77,782          +0.08%
Dr                     9,028,392|  9,028,168          -0.00%
Dw                     6,292,998|  6,293,130          +0.00%
EstimatedCycles       59,015,985| 59,000,437          -0.03%
I1MissRate                     0|          0          -6.08%
I1mr                      54,662|     51,335          -6.09%
ILmr                         905|        899          -0.66%
Ir                    36,955,313| 36,951,019          -0.01%
L1HitRate                     99|         99          +0.01%
L1hits                51,535,030| 51,534,357          -0.00%
LLHitRate                      1|          1          -0.61%
LLMissRate                     0|          0          +0.11%
LLdMissRate                    1|          1          +0.10%
LLhits                   615,920|    612,084          -0.62%
LLiMissRate                    0|          0          -0.65%
RamHitRate                     0|          0          +0.11%
RamHits                  125,753|    125,876          +0.10%
TotalRW               52,276,703| 52,272,317          -0.01%

compile_demo_art_gungraun::compile_group::compile_to_proto with_setup_5:(load_from_name(valley-of-spires))
Instructions: 27,074,484 (master) → 27,076,165 (HEAD) : $$\color{red}+0.01\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.14%
D1mr                     370,257|    369,859          -0.11%
D1mw                     105,136|    104,888          -0.24%
DLmr                      19,778|     19,784          +0.03%
DLmw                      43,916|     43,956          +0.09%
Dr                     6,631,512|  6,631,752          +0.00%
Dw                     4,601,571|  4,601,651          +0.00%
EstimatedCycles       42,308,421| 42,299,606          -0.02%
I1MissRate                     0|          0          -5.78%
I1mr                      40,808|     38,450          -5.78%
ILmr                         841|        835          -0.71%
Ir                    27,074,484| 27,076,165          +0.01%
L1HitRate                     99|         99          +0.01%
L1hits                37,791,366| 37,796,371          +0.01%
LLHitRate                      1|          1          -0.68%
LLMissRate                     0|          0          +0.06%
LLdMissRate                    1|          1          +0.07%
LLhits                   451,666|    448,622          -0.67%
LLiMissRate                    0|          0          -0.72%
RamHitRate                     0|          0          +0.06%
RamHits                   64,535|     64,575          +0.06%
TotalRW               38,307,567| 38,309,568          +0.01%

🔄 Executor Update

update_executor_gungraun::update_group::update_executor with_setup_0:(setup_update_executor(isometric-fountain))
Instructions: 87,841,087 (master) → 87,833,295 (HEAD) : $$\color{lime}-0.01\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          +0.52%
D1mr                     769,849|    773,367          +0.46%
D1mw                     235,987|    237,189          +0.51%
DLmr                      36,430|     35,691          -2.03%
DLmw                      89,726|     89,298          -0.48%
Dr                    22,638,197| 22,631,359          -0.03%
Dw                    15,115,649| 15,104,027          -0.08%
EstimatedCycles      133,898,505|133,858,687          -0.03%
I1MissRate                     0|          0          +0.85%
I1mr                     116,687|    117,673          +0.84%
ILmr                         960|        914          -4.79%
Ir                    87,841,087| 87,833,295          -0.01%
L1HitRate                     99|         99          -0.00%
L1hits               124,472,410|124,440,452          -0.03%
LLHitRate                      1|          1          +0.72%
LLMissRate                     0|          0          -0.93%
LLdMissRate                    0|          0          -0.88%
LLhits                   995,407|  1,002,326          +0.70%
LLiMissRate                    0|          0          -4.78%
RamHitRate                     0|          0          -0.93%
RamHits                  127,116|    125,903          -0.95%
TotalRW              125,594,933|125,568,681          -0.02%

update_executor_gungraun::update_group::update_executor with_setup_1:(setup_update_executor(painted-dreams))
Instructions: 49,445,993 (master) → 49,396,234 (HEAD) : $$\color{lime}-0.10\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          +0.44%
D1mr                     429,050|    431,248          +0.51%
D1mw                     129,684|    129,191          -0.38%
DLmr                         522|        406         -22.22%
DLmw                      14,270|     14,561          +2.04%
Dr                    12,687,702| 12,674,284          -0.11%
Dw                     8,487,568|  8,471,775          -0.19%
EstimatedCycles       73,593,451| 73,531,421          -0.08%
I1MissRate                     0|          0          +1.88%
I1mr                      72,098|     73,383          +1.78%
ILmr                         170|        161          -5.29%
Ir                    49,445,993| 49,396,234          -0.10%
L1HitRate                     99|         99          -0.01%
L1hits                69,990,431| 69,908,471          -0.12%
LLHitRate                      1|          1          +0.57%
LLMissRate                     0|          0          +1.22%
LLdMissRate                    0|          0          +1.32%
LLhits                   615,870|    618,694          +0.46%
LLiMissRate                    0|          0          -5.20%
RamHitRate                     0|          0          +1.22%
RamHits                   14,962|     15,128          +1.11%
TotalRW               70,621,263| 70,542,293          -0.11%

update_executor_gungraun::update_group::update_executor with_setup_2:(setup_update_executor(procedural-string-lights)...
Instructions: 11,399,270 (master) → 11,409,543 (HEAD) : $$\color{red}+0.09\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          +0.29%
D1mr                      98,126|     98,558          +0.44%
D1mw                      30,483|     30,590          +0.35%
DLmr                          36|         33          -8.33%
DLmw                       1,966|      2,612         +32.86%
Dr                     2,918,156|  2,920,844          +0.09%
Dw                     1,944,932|  1,948,714          +0.19%
EstimatedCycles       16,910,754| 16,948,975          +0.23%
I1MissRate                     0|          0          +0.13%
I1mr                      17,275|     17,313          +0.22%
ILmr                         160|        156          -2.50%
Ir                    11,399,270| 11,409,543          +0.09%
L1HitRate                     99|         99          -0.00%
L1hits                16,116,474| 16,132,640          +0.10%
LLHitRate                      1|          1          -0.15%
LLMissRate                     0|          0         +29.42%
LLdMissRate                    0|          0         +31.94%
LLhits                   143,722|    143,660          -0.04%
LLiMissRate                    0|          0          -2.59%
RamHitRate                     0|          0         +29.42%
RamHits                    2,162|      2,801         +29.56%
TotalRW               16,262,358| 16,279,101          +0.10%

update_executor_gungraun::update_group::update_executor with_setup_3:(setup_update_executor(parametric-dunescape))
Instructions: 34,109,342 (master) → 34,116,115 (HEAD) : $$\color{red}+0.02\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          +0.29%
D1mr                     297,165|    297,954          +0.27%
D1mw                      88,804|     89,086          +0.32%
DLmr                          97|         92          -5.15%
DLmw                       9,284|      9,178          -1.14%
Dr                     8,774,668|  8,774,255          -0.00%
Dw                     5,873,141|  5,871,596          -0.03%
EstimatedCycles       50,727,051| 50,721,152          -0.01%
I1MissRate                     0|          0          -8.36%
I1mr                      34,971|     32,054          -8.34%
ILmr                         157|        157          +0.00%
Ir                    34,109,342| 34,116,115          +0.02%
L1HitRate                     99|         99          +0.00%
L1hits                48,336,211| 48,342,872          +0.01%
LLHitRate                      1|          1          -0.43%
LLMissRate                     0|          0          -1.17%
LLdMissRate                    0|          0          -1.17%
LLhits                   411,402|    409,667          -0.42%
LLiMissRate                    0|          0          -0.02%
RamHitRate                     0|          0          -1.17%
RamHits                    9,538|      9,427          -1.16%
TotalRW               48,757,151| 48,761,966          +0.01%

update_executor_gungraun::update_group::update_executor with_setup_4:(setup_update_executor(red-dress))
Instructions: 105,767,044 (master) → 105,815,983 (HEAD) : $$\color{red}+0.05\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          +0.71%
D1mr                     892,514|    901,282          +0.98%
D1mw                     275,742|    275,790          +0.02%
DLmr                      82,426|     88,129          +6.92%
DLmw                     121,274|    120,969          -0.25%
Dr                    27,187,227| 27,195,530          +0.03%
Dw                    18,160,340| 18,173,289          +0.07%
EstimatedCycles      162,479,935|162,765,256          +0.18%
I1MissRate                     0|          0          +3.16%
I1mr                     135,845|    140,199          +3.21%
ILmr                       1,264|      1,281          +1.34%
Ir                   105,767,044|105,815,983          +0.05%
L1HitRate                     99|         99          -0.01%
L1hits               149,810,510|149,867,531          +0.04%
LLHitRate                      1|          1          +0.66%
LLMissRate                     0|          0          +2.59%
LLdMissRate                    0|          0          +2.60%
LLhits                 1,099,137|  1,106,892          +0.71%
LLiMissRate                    0|          0          +1.30%
RamHitRate                     0|          0          +2.59%
RamHits                  204,964|    210,379          +2.64%
TotalRW              151,114,611|151,184,802          +0.05%

update_executor_gungraun::update_group::update_executor with_setup_5:(setup_update_executor(valley-of-spires))
Instructions: 75,390,697 (master) → 75,390,227 (HEAD) : $$\color{lime}-0.00\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          -0.06%
D1mr                     642,520|    641,895          -0.10%
D1mw                     201,022|    201,392          +0.18%
DLmr                      16,588|     16,515          -0.44%
DLmw                      60,203|     59,089          -1.85%
Dr                    19,564,937| 19,567,819          +0.01%
Dw                    13,088,796| 13,094,465          +0.04%
EstimatedCycles      114,135,122|114,104,467          -0.03%
I1MissRate                     0|          0          -0.80%
I1mr                     100,341|     99,537          -0.80%
ILmr                         381|        418          +9.71%
Ir                    75,390,697| 75,390,227          -0.00%
L1HitRate                     99|         99          +0.00%
L1hits               107,100,547|107,109,687          +0.01%
LLHitRate                      1|          1          +0.00%
LLMissRate                     0|          0          -1.50%
LLdMissRate                    0|          0          -1.57%
LLhits                   866,711|    866,802          +0.01%
LLiMissRate                    0|          0          +9.71%
RamHitRate                     0|          0          -1.50%
RamHits                   77,172|     76,022          -1.49%
TotalRW              108,044,430|108,052,511          +0.01%

🚀 Render: Cold Execution

run_once_gungraun::run_once_group::run_once with_setup_0:(setup_run_once(isometric-fountain))
Instructions: 40,072,110 (master) → 42,038,540 (HEAD) : $$\color{red}+4.91\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          -2.54%
D1mr                     342,395|    347,149          +1.39%
D1mw                     121,197|    125,682          +3.70%
DLmr                       8,909|      9,097          +2.11%
DLmw                      12,739|     12,413          -2.56%
Dr                    10,125,331| 10,628,477          +4.97%
Dw                     7,216,093|  7,519,502          +4.20%
EstimatedCycles       61,358,046| 64,329,991          +4.84%
I1MissRate                     1|          1          +8.12%
I1mr                     294,041|    333,507         +13.42%
ILmr                       8,818|      9,094          +3.13%
Ir                    40,072,110| 42,038,540          +4.91%
L1HitRate                     99|         99          -0.02%
L1hits                56,655,901| 59,380,181          +4.81%
LLHitRate                      1|          1          +1.76%
LLMissRate                     0|          0          -4.18%
LLdMissRate                    0|          0          -5.05%
LLhits                   727,167|    775,734          +6.68%
LLiMissRate                    0|          0          -1.69%
RamHitRate                     0|          0          -4.18%
RamHits                   30,466|     30,604          +0.45%
TotalRW               57,413,534| 60,186,519          +4.83%

run_once_gungraun::run_once_group::run_once with_setup_1:(setup_run_once(painted-dreams))
Instructions: 260,848,988 (master) → 262,465,505 (HEAD) : $$\color{red}+0.62\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     2|          2          -0.25%
D1mr                   1,428,959|  1,435,691          +0.47%
D1mw                     685,654|    695,279          +1.40%
DLmr                       4,924|      5,086          +3.29%
DLmw                      69,379|     69,445          +0.10%
Dr                    58,068,711| 58,633,132          +0.97%
Dw                    39,476,883| 39,915,604          +1.11%
EstimatedCycles      376,205,474|379,265,987          +0.81%
I1MissRate                     1|          1          +4.71%
I1mr                   1,699,965|  1,791,114          +5.36%
ILmr                      10,783|     10,916          +1.23%
Ir                   260,848,988|262,465,505          +0.62%
L1HitRate                     99|         99          -0.02%
L1hits               354,580,004|357,092,157          +0.71%
LLHitRate                      1|          1          +2.13%
LLMissRate                     0|          0          -0.30%
LLdMissRate                    0|          0          -0.71%
LLhits                 3,729,492|  3,836,637          +2.87%
LLiMissRate                    0|          0          +0.61%
RamHitRate                     0|          0          -0.30%
RamHits                   85,086|     85,447          +0.42%
TotalRW              358,394,582|361,014,241          +0.73%

run_once_gungraun::run_once_group::run_once with_setup_2:(setup_run_once(procedural-string-lights))
Instructions: 17,489,984 (master) → 17,829,218 (HEAD) : $$\color{red}+1.94\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     1|          1          -0.03%
D1mr                      68,939|     70,210          +1.84%
D1mw                      37,964|     38,764          +2.11%
DLmr                       1,938|      2,039          +5.21%
DLmw                       3,030|      3,194          +5.41%
Dr                     4,325,056|  4,416,270          +2.11%
Dw                     3,220,916|  3,278,030          +1.77%
EstimatedCycles       26,274,086| 26,823,976          +2.09%
I1MissRate                     1|          1          +6.39%
I1mr                     113,912|    123,538          +8.45%
ILmr                       6,861|      7,114          +3.69%
Ir                    17,489,984| 17,829,218          +1.94%
L1HitRate                     99|         99          -0.03%
L1hits                24,815,141| 25,291,006          +1.92%
LLHitRate                      1|          1          +3.34%
LLMissRate                     0|          0          +2.39%
LLdMissRate                    0|          0          +3.30%
LLhits                   208,986|    220,165          +5.35%
LLiMissRate                    0|          0          +1.71%
RamHitRate                     0|          0          +2.39%
RamHits                   11,829|     12,347          +4.38%
TotalRW               25,035,956| 25,523,518          +1.95%

run_once_gungraun::run_once_group::run_once with_setup_3:(setup_run_once(parametric-dunescape))
Instructions: 21,488,690 (master) → 21,384,931 (HEAD) : $$\color{lime}-0.48\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     2|          2          +0.69%
D1mr                     103,557|    102,070          -1.44%
D1mw                      77,385|     76,758          -0.81%
DLmr                       4,296|      4,297          +0.02%
DLmw                       6,467|      6,063          -6.25%
Dr                     5,189,504|  5,101,596          -1.69%
Dw                     3,995,422|  3,913,614          -2.05%
EstimatedCycles       32,211,456| 31,924,487          -0.89%
I1MissRate                     0|          0          +2.68%
I1mr                      82,123|     83,916          +2.18%
ILmr                       5,423|      5,419          -0.07%
Ir                    21,488,690| 21,384,931          -0.48%
L1HitRate                     99|         99          -0.01%
L1hits                30,410,551| 30,137,397          -0.90%
LLHitRate                      1|          1          +0.93%
LLMissRate                     0|          0          -1.64%
LLdMissRate                    0|          0          -1.93%
LLhits                   246,879|    246,965          +0.03%
LLiMissRate                    0|          0          +0.41%
RamHitRate                     0|          0          -1.64%
RamHits                   16,186|     15,779          -2.51%
TotalRW               30,673,616| 30,400,141          -0.89%

run_once_gungraun::run_once_group::run_once with_setup_4:(setup_run_once(red-dress))
Instructions: 1,968,570,015 (master) → 1,970,203,454 (HEAD) : $$\color{red}+0.08\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     1|          1          -2.42%
D1mr                   3,083,556|  2,993,959          -2.91%
D1mw                   1,563,088|  1,546,558          -1.06%
DLmr                      87,214|     86,579          -0.73%
DLmw                     505,292|    508,826          +0.70%
Dr                   476,573,097|477,169,580          +0.13%
Dw                   312,814,391|313,318,582          +0.16%
EstimatedCycles      2,805,289,769|2,810,882,816          +0.20%
I1MissRate                     0|          0         +29.62%
I1mr                   2,683,565|  3,481,378         +29.73%
ILmr                       7,875|      8,049          +2.21%
Ir                   1,968,570,015|1,970,203,454          +0.08%
L1HitRate                    100|        100          -0.02%
L1hits               2,750,627,294|2,752,669,721          +0.07%
LLHitRate                      0|          0         +10.12%
LLMissRate                     0|          0          +0.41%
LLdMissRate                    0|          0          +0.35%
LLhits                 6,729,828|  7,418,441         +10.23%
LLiMissRate                    0|          0          +2.12%
RamHitRate                     0|          0          +0.41%
RamHits                  600,381|    603,454          +0.51%
TotalRW              2,757,957,503|2,760,691,616          +0.10%

run_once_gungraun::run_once_group::run_once with_setup_5:(setup_run_once(valley-of-spires))
Instructions: 31,922,703 (master) → 33,965,778 (HEAD) : $$\color{red}+6.40\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     2|          2          -0.39%
D1mr                     217,660|    229,177          +5.29%
D1mw                      94,871|    100,437          +5.87%
DLmr                       7,333|      7,471          +1.88%
DLmw                      11,953|     12,148          +1.63%
Dr                     7,979,304|  8,482,516          +6.31%
Dw                     5,836,154|  6,145,173          +5.29%
EstimatedCycles       48,761,611| 51,834,367          +6.30%
I1MissRate                     1|          1          +6.26%
I1mr                     251,234|    284,051         +13.06%
ILmr                       6,327|      6,589          +4.14%
Ir                    31,922,703| 33,965,778          +6.40%
L1HitRate                     99|         99          -0.03%
L1hits                45,174,396| 47,979,802          +6.21%
LLHitRate                      1|          1          +2.75%
LLMissRate                     0|          0          -3.69%
LLdMissRate                    0|          0          -3.92%
LLhits                   538,152|    587,457          +9.16%
LLiMissRate                    0|          0          -2.12%
RamHitRate                     0|          0          -3.69%
RamHits                   25,613|     26,208          +2.32%
TotalRW               45,738,161| 48,593,467          +6.24%

⚡ Render: Cached Execution

run_cached_gungraun::run_cached_group::run_cached with_setup_0:(setup_run_cached(isometric-fountain))
Instructions: 193,065 (master) → 193,776 (HEAD) : $$\color{red}+0.37\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          +0.33%
D1mr                       4,354|      4,371          +0.39%
D1mw                       1,931|      1,941          +0.52%
DLmr                           3|          3          +0.00%
DLmw                          12|         14         +16.67%
Dr                       105,847|    105,960          +0.11%
Dw                        96,170|     96,266          +0.10%
EstimatedCycles          422,754|    423,944          +0.28%
I1MissRate                     0|          0          +5.27%
I1mr                         318|        336          +5.66%
ILmr                          27|         28          +3.70%
Ir                       193,065|    193,776          +0.37%
L1HitRate                     98|         98          -0.01%
L1hits                   388,479|    389,354          +0.23%
LLHitRate                      2|          2          +0.41%
LLMissRate                     0|          0          +6.89%
LLdMissRate                    0|          0         +13.22%
LLhits                     6,561|      6,603          +0.64%
LLiMissRate                    0|          0          +3.32%
RamHitRate                     0|          0          +6.89%
RamHits                       42|         45          +7.14%
TotalRW                  395,082|    396,002          +0.23%

run_cached_gungraun::run_cached_group::run_cached with_setup_1:(setup_run_cached(painted-dreams))
Instructions: 228,536 (master) → 228,370 (HEAD) : $$\color{lime}-0.07\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          +0.38%
D1mr                       4,751|      4,781          +0.63%
D1mw                       2,637|      2,632          -0.19%
DLmr                          29|         29          +0.00%
DLmw                          30|          7         -76.67%
Dr                       150,903|    150,853          -0.03%
Dw                       142,381|    142,321          -0.04%
EstimatedCycles          557,836|    556,814          -0.18%
I1MissRate                     0|          0          +6.83%
I1mr                         311|        332          +6.75%
ILmr                         115|        107          -6.96%
Ir                       228,536|    228,370          -0.07%
L1HitRate                     99|         99          -0.01%
L1hits                   514,121|    513,799          -0.06%
LLHitRate                      1|          1          +1.08%
LLMissRate                     0|          0         -17.77%
LLdMissRate                    0|          0         -38.96%
LLhits                     7,525|      7,602          +1.02%
LLiMissRate                    0|          0          -6.89%
RamHitRate                     0|          0         -17.77%
RamHits                      174|        143         -17.82%
TotalRW                  521,820|    521,544          -0.05%

run_cached_gungraun::run_cached_group::run_cached with_setup_2:(setup_run_cached(parametric-dunescape))
Instructions: 133,661 (master) → 133,839 (HEAD) : $$\color{red}+0.13\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     2|          2          +0.36%
D1mr                       2,322|      2,323          +0.04%
D1mw                       2,002|      2,019          +0.85%
DLmr                           3|          3          +0.00%
DLmw                           5|          5          +0.00%
Dr                       108,588|    108,646          +0.05%
Dw                       106,390|    106,449          +0.06%
EstimatedCycles          368,299|    368,650          +0.10%
I1MissRate                     0|          0          -1.32%
I1mr                         336|        332          -1.19%
ILmr                          26|         26          +0.00%
Ir                       133,661|    133,839          +0.13%
L1HitRate                     99|         99          -0.00%
L1hits                   343,979|    344,260          +0.08%
LLHitRate                      1|          1          +0.22%
LLMissRate                     0|          0          -0.08%
LLdMissRate                    0|          0          -0.05%
LLhits                     4,626|      4,640          +0.30%
LLiMissRate                    0|          0          -0.13%
RamHitRate                     0|          0          -0.08%
RamHits                       34|         34          +0.00%
TotalRW                  348,639|    348,934          +0.08%

run_cached_gungraun::run_cached_group::run_cached with_setup_3:(setup_run_cached(red-dress))
Instructions: 500,200 (master) → 499,087 (HEAD) : $$\color{lime}-0.22\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                    34|         34          +0.26%
D1mr                      55,402|     55,447          +0.08%
D1mw                      27,232|     27,240          +0.03%
DLmr                         129|        126          -2.33%
DLmw                       1,172|      1,216          +3.75%
Dr                       132,435|    132,185          -0.19%
Dw                       112,299|    112,070          -0.20%
EstimatedCycles        1,122,724|  1,122,632          -0.01%
I1MissRate                     0|          0          +2.34%
I1mr                         331|        338          +2.11%
ILmr                         230|        231          +0.43%
Ir                       500,200|    499,087          -0.22%
L1HitRate                     89|         89          -0.04%
L1hits                   661,969|    660,317          -0.25%
LLHitRate                     11|         11          +0.24%
LLMissRate                     0|          0          +2.96%
LLdMissRate                    1|          1          +3.35%
LLhits                    81,434|     81,452          +0.02%
LLiMissRate                    0|          0          +0.66%
RamHitRate                     0|          0          +2.96%
RamHits                    1,531|      1,573          +2.74%
TotalRW                  744,934|    743,342          -0.21%

run_cached_gungraun::run_cached_group::run_cached with_setup_4:(setup_run_cached(valley-of-spires))
Instructions: 185,807 (master) → 185,813 (HEAD) : $$\color{red}+0.00\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          -0.86%
D1mr                       4,343|      4,304          -0.90%
D1mw                       1,931|      1,915          -0.83%
DLmr                           3|          3          +0.00%
DLmw                          14|         40        +185.71%
Dr                       103,294|    103,288          -0.01%
Dw                        94,365|     94,341          -0.03%
EstimatedCycles          411,130|    411,738          +0.15%
I1MissRate                     0|          0          +5.77%
I1mr                         312|        330          +5.77%
ILmr                          27|         27          +0.00%
Ir                       185,807|    185,813          +0.00%
L1HitRate                     98|         98          +0.01%
L1hits                   376,880|    376,893          +0.00%
LLHitRate                      2|          2          -0.96%
LLMissRate                     0|          0         +59.10%
LLdMissRate                    0|          0        +152.98%
LLhits                     6,542|      6,479          -0.96%
LLiMissRate                    0|          0          -0.00%
RamHitRate                     0|          0         +59.10%
RamHits                       44|         70         +59.09%
TotalRW                  383,466|    383,442          -0.01%

@Keavon

Keavon commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

Performance regression is reasonable in that actual work is now occurring that was previously skipped at the cost of correctness about path winding, which only happened to work in practice in some (but not all) cases.

@Keavon
Keavon merged commit 2fa6b74 into master Aug 19, 2026
10 of 11 checks passed
@Keavon
Keavon deleted the derived-face-fill branch August 19, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant