feat(acp): add ACP client and external subagent providers (DSH 2.8) - #213
Merged
Patel230 merged 1 commit intoAug 20, 2026
Merged
Conversation
Port of DSH acp client and subagent-acp, subagent-claude-code, subagent-codex providers. - acp: Implemented JSON-RPC 2.0 stdio client with initialize handshake, session/new, session/prompt, session/cancel, and streamed update notifications. - acp: Connected server-to-client permission requests via OnPermissionRequest callback matching ACP outcome schema. - acp: Handled process group lifecycle and disposal across Unix and Windows. - multiagent: Added SubagentProvider registry with capability guards (outputSchema, maxDepth, supportedPersonas). - multiagent: Added built-in ACP providers for generic acp, claude-code, and codex. - tests: Full test coverage for ACP client-server round-trip, permission routing, capability rejections, structured output parsing, and lifecycle disposal.
Patel230
deleted the
feat/dsh-harness-rfc-2.8-acp-client-subagent-providers
branch
August 20, 2026 03:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of DSH
acp/client andsubagent/subagent-acp,subagent-claude-code,subagent-codexproviders into Hawk.Key Changes
Clientcommunicating via newline-delimited JSON-RPC 2.0 on stdio with initialize handshake,NewSession,Prompt,Cancel, and streamed notifications.OnPermissionRequestcallback conforming to ACP outcome schema.SubagentProviderinterface andProviderRegistrywith capability guards (outputSchema,maxDepth,supportedPersonas).GenericACPProviderand default providers foracp,claude-code, andcodex.Gated by gofmt, go vet, go test -race, make lint, and layer boundary guards.