feat(terminal): add persistent PTY terminal store and tools (DSH 2.9) - #214
Merged
Merged
Conversation
Port of DSH terminal/pty, terminal/terminal-bash, and terminal/tool-terminal into Hawk. - terminal: Implemented TerminalStore managing persistent interactive PTY sessions with branded IDs (terminal-<N>). - terminal: Enforced exact session ownership and isolation (cross-session access denied). - terminal: Implemented zero-CGO PTY backend on Unix/Darwin/Linux via creack/pty with bounded buffering (64 KiB read cap / 512 KiB buffer cap). - terminal: Integrated sandbox policies (SecurityWorkspace, SecurityStrict) and process-tree disposal. - tools: Added TerminalCreate, TerminalSend, TerminalRead, TerminalList, TerminalResize, and TerminalKill tools to essentialTools. - tests: Full test coverage for lifecycle, session authorization, bounded reads, resize, and session teardown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of DSH
terminal/pty,terminal/terminal-bash, andterminal/tool-terminalinto Hawk.Key Changes
TerminalStoremanaging persistent interactive PTY sessions with branded IDs (terminal-<N>).github.com/creack/ptywith bounded buffering (64 KiB read cap / 512 KiB buffer cap).SecurityWorkspace,SecurityStrict) and process-tree disposal.TerminalCreate,TerminalSend,TerminalRead,TerminalList,TerminalResize, andTerminalKilltools toessentialTools.Gated by gofmt, go vet, go test -race, make lint, and layer boundary guards.