fix(dialtesting): upstream Lightpanda 0.4 screenshot integration - #209
Merged
Conversation
|
zhangwenjie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
leecha
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream the Lightpanda 0.4.0-g1 integration currently carried by DataKit MR !4157 as vendor patches. Enable optional PNG screenshots and viewport settings, use the updated resource/CIDR arguments, bound screenshot capture and clean discarded retry images. Avoid creating an uncancelled intermediate context for deadline-bearing actions.
Validation:
go test -race ./dialtesting/browserdial/...passed. Existing argument tests were updated for the new CLI. Real Lightpanda binary compatibility was not exercised. Repository-wide lint reported 67 issues outside these changed files; copyright check reported existing missing headers (headers added to the migrated files). Full make test is time-bounded and not a release gate proven by this PR.Requires Lightpanda 0.4.0-g1; retains the parameter adaptation already shipped in the DataKit change.