Skip to content

fix(dialtesting): upstream Lightpanda 0.4 screenshot integration - #209

Merged
NaR82n merged 1 commit into
mainfrom
feat-lightpanda-screenshot-upstream
Sep 9, 2026
Merged

fix(dialtesting): upstream Lightpanda 0.4 screenshot integration#209
NaR82n merged 1 commit into
mainfrom
feat-lightpanda-screenshot-upstream

Conversation

@NaR82n

@NaR82n NaR82n commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Upstream the Lightpanda 0.4.0-g1 integration currently carried by DataKit MR !4157 as vendor patches. Enable optional PNG screenshots and viewport settings, use the updated resource/CIDR arguments, bound screenshot capture and clean discarded retry images. Avoid creating an uncancelled intermediate context for deadline-bearing actions.

Validation: go test -race ./dialtesting/browserdial/... passed. Existing argument tests were updated for the new CLI. Real Lightpanda binary compatibility was not exercised. Repository-wide lint reported 67 issues outside these changed files; copyright check reported existing missing headers (headers added to the migrated files). Full make test is time-bounded and not a release gate proven by this PR.

Requires Lightpanda 0.4.0-g1; retains the parameter adaptation already shipped in the DataKit change.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zhangwenjie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@NaR82n
NaR82n merged commit ce14204 into main Sep 9, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants