feat(keyring): credential-keyring module (split from #181) - #188
Open
raymondginger2018-sudo wants to merge 2 commits into
Open
feat(keyring): credential-keyring module (split from #181)#188raymondginger2018-sudo wants to merge 2 commits into
raymondginger2018-sudo wants to merge 2 commits into
Conversation
This was referenced Aug 22, 2026
Contributor
Author
|
@Zongwei9888 Per your 08-17 suggestion on #181, this is the keyring module split out as an independent PR: new files only ( CI status: Python CI / Desktop CI / Linting all green. The Security CI failure is repo-wide and unrelated to this PR — the sidecar lock pins Ready for review whenever you have a moment — this one and #189 are the two that can merge in any order. |
GenAI course lesson 09: never put secrets in plaintext config. Keyring stores secrets out-of-band (DEEPCODE_KEYRING env knob), get/set/delete, secret-masked repr. All new files; no existing behavior touched.
raymondginger2018-sudo
force-pushed
the
pr181/keyring
branch
from
August 25, 2026 07:01
7e1baa8 to
7e88b9d
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the keyring module out of #181 (maintainer suggestion: split the +3031-line PR so each module can merge independently). This PR is new files only — no existing behavior is modified.
GenAI course lesson 09: secrets must not live in plaintext config.
core/keyring.pyprovides:Keyringstores secrets out-of-band (env knobDEEPCODE_KEYRING, default off)get/set/delete/has, secret-masked repr (never prints values)DEEPCODE_KEYRING=memin tests)Tests
tests/test_keyring.py— 13 passed locally (also covered by CI).