Skip to content

Split camera.c - #827

Open
someone2639 wants to merge 43 commits into
HackerN64:develop/3.0.0from
someone2639:camera_separation
Open

Split camera.c#827
someone2639 wants to merge 43 commits into
HackerN64:develop/3.0.0from
someone2639:camera_separation

Conversation

@someone2639

@someone2639 someone2639 commented Aug 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

camera.c 11148 -> 3178 2454 2187 lines

See README for details on file structure

TODO's for the PR:

@gheskett gheskett added enhancement New feature or request cleanup Removal of useless or bloat code/features labels Aug 28, 2024
@gheskett gheskett added this to the 3.0 milestone Aug 28, 2024
@gheskett gheskett added the monkaS monkaS label Aug 28, 2024
@someone2639

someone2639 commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator Author

I believe this PR is ready for initial review. As always, the README has the intended file structure in case there are comments on that.

Things to consider:

  • Many enums and structs are still in camera.h, due to being a bit involved to separate into their uses (it would pollute the PR's changed files too)
  • The functions in Image 1 might warrant a new file, camera_sound.c
  • The functions in Image 2 might warrant a new file, camera_shake.c, or integration into the existing camera_math.c
  • I have put a function only used by the behind_mario mode in its respective file, but it might be worth placing it in camera_math.c instead.

Image 1:
image

Image 2:
image

@someone2639
someone2639 marked this pull request as ready for review August 29, 2024 17:57
@someone2639
someone2639 requested a review from gheskett as a code owner August 29, 2024 17:57
@someone2639 someone2639 changed the title Split camera.c (Tracking) Split camera.c Aug 29, 2024
@arthurtilly

arthurtilly commented Jan 30, 2025

Copy link
Copy Markdown
Collaborator

i see a TODO in the PR description so either do it or update the description if its outdated...

@someone2639

someone2639 commented Jan 30, 2025

Copy link
Copy Markdown
Collaborator Author

updated

arthurtilly
arthurtilly reviewed Jan 30, 2025
View reviewed changes
Comment thread src/camera/README.md Outdated
arthurtilly
arthurtilly reviewed Jan 30, 2025
View reviewed changes
Comment thread src/game/mario_actions_cutscene.c
@farisawan-2000
farisawan-2000 requested a review from Reonu as a code owner April 23, 2025 21:23
@someone2639

someone2639 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

ready for another lap 🏇 (resolved merge conflicts, this is the camera PR not the crash screen one)

someone2639 and others added 2 commits September 18, 2026 21:37
someone2639
merge memes 1.5
4efc830
@aglab2 someone2639
Split vanillla object from levels allowing pruning vanilla assets on …
89c7998 
…fast64 imports and managing vanilla objects independently of levels (HackerN64#796)

* Move level script to bank 0x1A

* Decouple vanilla objects in a separate bank

* Rollback group level scripts move, fixed nits

* Move actors_vanilla to actors/vanilla_actors

* Make EU translation segment last, remove vanilla objects segments copypaste

* Added LOAD_VANILLA_OBJECTS segment id stub
@someone2639
someone2639 changed the base branch from legacy/3.0.0 to develop/3.0.0 September 19, 2026 01:45
@someone2639

someone2639 commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator Author

ready for another lap 🏇 (resolved merge conflicts,

@someone2639 someone2639 mentioned this pull request Sep 19, 2026
Open
6 of 7 tasks
@someone2639 someone2639 added the needs fast64 integration Dependent on changes to fast64 label Sep 19, 2026
@someone2639

someone2639 commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator Author

ready for another lap 🏇

@someone2639

someone2639 commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator Author

wrong PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arthurtilly arthurtilly arthurtilly left review comments
@gheskett gheskett Awaiting requested review from gheskett gheskett is a code owner
@Reonu Reonu Awaiting requested review from Reonu Reonu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@someone2639 someone2639

Labels

cleanup Removal of useless or bloat code/features enhancement New feature or request monkaS monkaS needs fast64 integration Dependent on changes to fast64

Projects

HackerSM64 3.0 (Major Feature Update)
Status: In progress

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@someone2639 @arthurtilly @gheskett @aglab2