[Afton-programmer]

I reviewed the project end to end and fixed several issues found along the way. The main one is the first-launch permission UX.

1. Storage permission was auto-requested on app entry (main fix)

The onboarding welcome page called autoRequestMissing() from onViewCreated(), so the moment the page appeared the app automatically opened the All files access settings screen, then the runtime media dialogs, then the notification dialog — before the user tapped anything. Users perceive this as the app grabbing permissions on its own, which is intrusive.

Every permission is now requested only when the user taps its row's Grant button — the same pattern the Notifications row already used — which also matches AGENTS.md section 6 (permissions only when truly needed).

• Removed autoRequestMissing() and its call from onViewCreated()
• Files row: on Android 11+ it opens the all-files settings screen on tap; on Android 8-10 it now falls back to the runtime storage dialog (previously the button did nothing on those versions)
• Both settings intents are wrapped in ActivityNotFoundException handling (toast instead of crash on devices without those settings pages)
• Removed the unused PermissionUtils.requestPermissions(Activity) helper that silently opened the all-files settings screen (dead code, no callers)

2. Lifecycle / memory-leak fixes

• PluginManager is now initialized in GhostIdeAppLoader, so plugins receive the file-manager host on first launch; previously the registration NPE was silently swallowed until EditorActivity had been opened once
• Removed PluginManager's write-only activity fields (static leaks) and added clearEditorActivityReferences() / clearFileManagerActivityReferences(), called from the activities' onDestroy() so plugins no longer retain destroyed activities
• FileManagerActivity.onDestroy() now always disposes the host registration, git helper and executor; previously an exception from unregisterReceiver() skipped all of them. The unregistration is guarded, the binding is null-checked and the delayed plugin-host Runnable is cancelled
• OnboardingViewModel.onCleared() now detaches its DebianInstaller listener (the installer keeps it in a static field, so the ViewModel leaked after onboarding)
• NetworkChangeReceiver ignores deliveries when no callback is attached (manifest-instantiated receivers would NPE)

3. Startup robustness

• extractCursorZip() now runs off the main thread, uses try-with-resources, rejects zip entries that escape the target directory (path traversal) and logs failures instead of silently ignoring them. The old code leaked streams on any read error and failed silently on every first launch, because storage permission is not granted yet at that point

Verification

• Debug APK built successfully with the repo's own GitHub Actions workflows (./gradlew assembleDebug) on my fork; CI is green
• No files were added/removed/moved, so map.md did not need an update (AGENTS.md section 8)
• The only intentional behavior change is that permission prompts no longer appear automatically; everything else preserves existing behavior

Suggestions (not included here; happy to send separate PRs)

• SplashActivity holds every launch for a fixed 3.8 s; shortening it would make the app feel much snappier
• TerminalActivity / TerminalBottomSheetFragment still auto-request POST_NOTIFICATIONS when opened; if the tap-only policy should apply everywhere, those need a small affordance too
• Security note: app/build.gradle contains the release keystore alias and passwords in plaintext in a public repo. Please rotate the keystore and move the credentials to CI secrets

---

سلام! پروژه را کامل بررسی کردم و چند مشکل را برطرف کردم؛ مهم‌ترینشان رفتار آزاردهنده‌ی درخواست خودکار دسترسی به فایل‌ها در اولین ورود بود که حالا فقط با کلیک کاربر روی دکمه‌ی Grant درخواست می‌شود. لطفاً نگاهی بیندازید؛ اگر مورد تأیید بود ممنون می‌شوم merge کنید.

[HanzoDev30]

@Afton-programmer Tank you in Fork

[Afton-programmer]

Two more fixes are pushed (cf3f4d1), covering today's feedback:

1. Icon pack / background plugin sections now hide when no plugin is installed.
Both sections built their row unconditionally, so with zero installed packs they just showed a dead "Default" row taking up space. They now build zero rows when listInstalled() is empty, and the existing hideSectionIfEmpty() in SettingActivity removes the whole card. Search also no longer tries to expand the hidden cards.

2. Section expansion no longer clips rows or freezes the screen:

• After the expand animation finished, the list kept a fixed pixel height captured at expand time, so any later content change (e.g. clearing the search filter) got clipped. The list now returns to wrap_content when the animation ends.
• If the list had not been laid out yet, expand() silently did nothing (measured height 0); it now falls back to measuring the list so the expansion always happens.
• The freeze: typing in search animated eight glass cards at once (height animator + LiquidGlass re-render every frame). Search now expands/collapses instantly via expand(false) / collapse(false); manual header taps keep the animation.

A fresh app-debug APK was built from this commit on the fork. (One of the two duplicate workflow runs hit a transient Maven Central download failure on unrelated jars and is being rerun; the identical build in the other workflow is green.)

---

دو مورد گفته‌شده انجام و push شد: بخش‌های «آیکون پک» و «پلاگین بک‌گراند» وقتی پلاگینی نصب نباشه کامل مخفی می‌شن، و مشکل نمایش ناقص هنگام expand (ارتفاع fix شده قدیمی) و هنگ کردن صفحه تنظیمات (انیمیشن همزمان هشت کارت شیشه‌ای در جستجو) برطرف شد. APK جدید هم از همین commit ساخته شد.