Document deployment.stagingRetention.maxCount and payloadRetention.maxSize - #668
Open
dawsontoth wants to merge 1 commit into
Open
Document deployment.stagingRetention.maxCount and payloadRetention.maxSize#668dawsontoth wants to merge 1 commit into
dawsontoth wants to merge 1 commit into
Conversation
…xSize Adds a deployment section to the configuration reference for the two retention knobs, and a 5.3 release note for staged build retention (HarperFast/harper#2315 step 4). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request documents the new deployment configuration options (payloadRetention.maxSize and stagingRetention.maxCount) and updates the v5.3 release notes to detail the staged build retention feature. The feedback suggests formatting adjustments to adhere to style guidelines, including using hyphens instead of em dashes as field separators in the configuration options documentation, and removing direct links to internal GitHub issues in the user-facing release notes.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-668 This preview will update automatically when you push new commits. |
dawsontoth
marked this pull request as ready for review
September 8, 2026 18:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to HarperFast/harper#2531 (step 4 of HarperFast/harper#2315).
Adds a
deploymentsection to the configuration reference covering the newstagingRetention.maxCountknob and the existing but previously undocumentedpayloadRetention.maxSize, and a 5.3 release note for staged build retention.Verified with
npm run format:check; no new pages or links beyond the existingdeploy_componentanchor.