Remove Table.oldestRetainedAuditTime() docs: the accessor is withdrawn before release - #669
Conversation
… catch-up horizon (#660)" The accessor this documented is being removed from harper#2458 before it ships. Per kriszyp's review there (Dawson's decision, 2026-09-10): it had no caller except harper#2448, a public single-number floor binds a contract a per-origin resume vector could not honor, and it created a second resume-validity path where replication already checks inside the operation. The floor stays as internal infrastructure; Table.subscribe consumes it inside the resume in #2448, and that is where consumer-facing docs belong. This reverts commit 0d151a2.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the documentation for the oldestRetainedAuditTime(): number method from reference/resources/resource-api.md and simplifies the description of the startTime property. There are no review comments, and I have no feedback to provide.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-669 This preview will update automatically when you push new commits. |
cb1kenobi
left a comment
cb1kenobi
left a comment
There was a problem hiding this comment.
This is a clean single-file revert of #660, removing documentation for Table.oldestRetainedAuditTime() because the accessor is being withdrawn before release. The removed anchor's only referrer — the startTime row cross-reference — is deleted in the same hunk, so no broken links remain, and the section separators stay balanced. All CI checks pass and the page matches its pre-#660 state. No blocking issues found.
—
Reviewed 943cb7e
🧹 Preview CleanupThe preview deployment for this PR has been removed. |
This branch was previously deployed
3 participants
Pure revert of #660's merge commit (
0d151a2c), which documentedTable.oldestRetainedAuditTime()under av5.3.0badge. That method is being removed from HarperFast/harper#2458 before it ships, so this page must not describe it.Why it is withdrawn — per kriszyp's review of harper#2458 (Dawson's decision, 2026-09-10): the accessor had no caller except harper#2448; a public single-number floor binds a contract that a per-origin resume vector could not honor; and it created a second resume-validity path where replication already checks inside the operation (
shouldForceBaseCopyForRetention). The audit retention floor itself still lands in #2458 — write-ahead, monotonic, verified — but as internal infrastructure.Table.subscribeconsumes it inside the resume in harper#2448, and the consumer-facing docs for that behavior belong to #2448.What this reverts: the
### oldestRetainedAuditTime(): numbersection and the reference #660 added to thestartTimerow of the subscription-options table.git revertapplied cleanly against currentmainwith no conflicts; the page is byte-identical to its pre-#660 state in that region.#666, which corrected the removed section's contract wording, is closed for the same reason.
🤖 Generated with Claude Code