fix(cli): validate and reject misplaced flags placed after '--' - #163
Merged
Merged
Conversation
- Add validateNoMisplacedFlags to detect when options are placed after '--' - Provide clear error messaging with guidance on flag placement - Allow literal files starting with '-' when existing on disk or index - Add unit test TestValidateNoMisplacedFlags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--(e.g.diffm main path -- -f sbs), Cobra stops parsing options and dumps the flag into positional arguments.What Changed
validateNoMisplacedFlagsto check positional arguments for arguments starting with-."-") and actual files on disk or in the Git index that start with-.rootCmd.Runso misplaced flags fail fast across all modes, including--parse-treeand--cst.cmd/diff_test.gocovering valid paths, stdin, misplaced short/long flags, and disk files starting with a dash.