fix(postprocess): suppress single-child wrappers with trailing delimiters - #168
Merged
Merged
Conversation
…ters Single-child statement wrappers ending in a semicolon were never suppressed because suppression required exact EndByte equality. Relax the check to cover single-child and scaffolding wrappers, removing phantom insert and delete boxes on moved lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
suppressCoextensiveWrappersrequired an exactEndBytematch before suppressing the parent wrapper.parent.EndBytewas always larger thannode.EndByte. So the wrapper was never suppressed, leaving phantom insert and delete boxes around lines that just moved.What Changed
suppressCoextensiveWrappersso single-child and scaffolding wrappers get suppressed if they shareStartBytewith the child, without needing exactEndByteequality.internal/postprocess/collapsing_test.goto verify that statement wrappers with trailing semicolons are properly dropped when their child moves.