fix(serialize): partition overlapping highlight spans into disjoint segments - #170
Merged
Merged
Conversation
…egments Spans could overlap when actions nested (e.g. update inside a move), breaking consumers that assume disjoint spans per line. Add partitionLineSpans: splits overlapping spans at boundary columns, picks one winner per segment (narrowest AST range, then narrowest span width, then action priority), coalesces adjacent same-action segments, and promotes updates carved out of a move back to move_update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BuildHighlightSpansemitted overlapping column ranges on the same line.What Changed
partitionLineSpansininternal/serialize/spans.goto split overlapping spans at column boundaries and pick one winner per atomic segment.move_update>update>move>insert>delete).move_update.internal/serialize/spans_test.gocovering coextensive duplicates, nested updates inside moves, three-way ties, and fallback ordering.TestNoOverlappingSpansintests/integration/pipeline_test.goto verify that all highlight spans are pairwise disjoint across all 150 golden test fixtures.