fix(postprocess): suppress nested moves under demoted ancestor moves - #171
Merged
Merged
Conversation
- Evict and suppress nested move actions whose ancestor move was demoted to delete/insert in normalizeMovesByStructure - Prevent ms.Src()[a.Node] == nil fallback from resurrecting descendant moves whose mappings were stripped - Add unit test verifying nested move suppression inside demoted ancestor containers
HarshK97
force-pushed
the
fix/postprocess-suppress-demoted-nested-moves
branch
from
September 20, 2026 17:17
dda9dfc to
c43c57e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
normalizeMovesByStructurewas re-runningshouldDemoteMovewhiledemoteMoveToDelInswas actively mutating the node mappings, making demotion decisions dependent on map mutation order.What Changed
toDemotemap and their descendants in ademotedDescendantsset during Pass 1, so Pass 2 never re-evaluates demotion checks against a mutating mapping.demotedDescendants, since the ancestor is already replaced as a full subtree Delete + Insert.switch a.Type.internal/postprocess/normalize_test.goverifying that nested moves under a demoted ancestor move are suppressed and only the ancestor's Delete + Insert survive.