The binary is 6.7 MB, not 3.2, and the self-test has 37 checks, not 21 - #124
Merged
Conversation
Three places said 3.2 MB and one said the self-test passes 21 of 21. Both were true when they were written. A publish just now gives one 6.7 MB ELF that passes 37 checks, so that is what they say — a doubling is what a year of columns, readers and views costs, and quoting the older figure is the more flattering mistake. Checked while running the gates the PRD names, all of which pass on main: self-test 37/37, helper check, the golden frame byte for byte, the AOT publish with no warnings, and the benchmarks with every budget met — 48.7 ms per thousand processes against a ceiling of 90, and 386 bytes allocated per sample.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three places said 3.2 MB and one said the self-test passes 21 of 21. Both were true when written. A publish just now gives one 6.7 MB ELF passing 37 checks, so that is what they say — a doubling is what a year of columns, readers and views costs, and quoting the older figure is the more flattering mistake.
Found while running the gates the PRD names, all of which pass on main:
--self-test--helper-check--compare-goldenDocs only.