Skip to content

Add a NotAvailableOnDesktop placeholder to the design system #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StylianosGakis wants to merge 1 commit into from
Closed

Add a NotAvailableOnDesktop placeholder to the design system #3366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/design-system/design-system-hedvig/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ kotlin {
implementation(libs.media3.exoplayer.dash)
implementation(libs.media3.ui)
}
jvmTest.dependencies {
implementation(libs.jetbrains.compose.ui.test)
implementation(libs.kotlin.test)
implementation(org.jetbrains.compose.ComposePlugin.DesktopDependencies.currentOs)
}
nativeMain.dependencies {
implementation(libs.metro.viewmodel)
implementation(libs.metro.viewmodel.compose)
Expand Down
25 changes: 25 additions & 0 deletions ...edvig/src/jvmMain/kotlin/com/hedvig/android/design/system/hedvig/NotAvailableOnDesktop.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package com.hedvig.android.design.system.hedvig

import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.padding
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.unit.dp

@Composable
fun NotAvailableOnDesktop(modifier: Modifier = Modifier) {
Box(
contentAlignment = Alignment.Center,
modifier = modifier.fillMaxSize().padding(16.dp),
) {
HedvigText(
text = "Not available on desktop",
style = HedvigTheme.typography.bodySmall,
color = HedvigTheme.colorScheme.textSecondary,
textAlign = TextAlign.Center,
)
}
}
20 changes: 20 additions & 0 deletions ...g/src/jvmTest/kotlin/com/hedvig/android/design/system/hedvig/NotAvailableOnDesktopTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package com.hedvig.android.design.system.hedvig

import androidx.compose.ui.test.ExperimentalTestApi
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.v2.runComposeUiTest
import kotlin.test.Test

@OptIn(ExperimentalTestApi::class)
class NotAvailableOnDesktopTest {
@Test
fun `shows the not available on desktop text`() = runComposeUiTest {
setContent {
HedvigTheme(darkTheme = false) {
NotAvailableOnDesktop()
}
}
onNodeWithText("Not available on desktop").assertIsDisplayed()
}
}
Loading