Repository navigation
Convert feature-insurance-certificate to a Kotlin Multiplatform module - #3369
Closed
StylianosGakis wants to merge 2 commits into
Closed
StylianosGakis wants to merge 2 commits into
StylianosGakis wants to merge 2 commits into
Conversation
The module now builds for JVM and Android, with its keys, screens, presenters, ViewModels and use cases in commonMain. Email validation uses the commonMain isValidEmail, and the overview screen hands the downloaded PDF out as a DownloadedFile. InsuranceEvidenceEntries stays in androidMain because sharing the PDF needs LocalContext and Context.sharePDF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI description
Turns
feature-insurance-certificateinto a Kotlin Multiplatform module (JVM and Android targets) with its keys, ViewModels, presenters, use cases and screens incommonMain. Part of making the whole app run on a second platform (desktop). Nothing changes on Android.Stacked on #3368, which this PR targets, because the email presenter now calls the
commonMainisValidEmailfrom there.Two things you would not guess from the diff:
DownloadedFileinstead ofjava.io.File. The entries file builds theFilefrom the same absolute path and hands it tosharePDFas before.androidMain, because sharing needsLocalContext. A later change adds a share seam and moves it.The first commit is pure renames, including the 24 unit tests moving to
jvmTestunchanged. Review the second.