Repository navigation
Convert feature-terminate-insurance to a Kotlin Multiplatform module - #3370
Closed
StylianosGakis wants to merge 2 commits into
Closed
StylianosGakis wants to merge 2 commits into
StylianosGakis wants to merge 2 commits into
Conversation
The module now builds with the JVM and Android targets and all of its code, including the entries function and deep link provider, compiles from commonMain. java.util.Locale becomes CommonLocale from core-locale; the date picker preview uses previewCommonLocale. Window size classes come from the JetBrains material3-window-size-class artifact that design-system-hedvig already uses. Unused imports of android.R.attr.text and kotlinx.datetime.toJavaLocalDate are dropped. Unit tests run as jvmTest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI description
Turns
feature-terminate-insuranceinto a Kotlin Multiplatform module (JVM and Android targets). Every Kotlin file, including the entries and deep links, is now incommonMain. Part of making the whole app run on a second platform (desktop). Nothing changes on Android.The first commit is 32 pure renames, including the 17 unit tests moving to
jvmTestunchanged. The second commit is five files, review that one:CommonLocale, which is a typealias ofjava.util.Localeon JVM and Android, so the same object reaches the picker. Only a preview's locale differs.isReturnDefaultValuesis dropped since no Android unit tests remain, andui-tooling-previewis declared explicitly as other KMP features do.