Repository navigation
Convert feature-forever to a Kotlin Multiplatform module - #3371
Closed
StylianosGakis wants to merge 2 commits into
Closed
StylianosGakis wants to merge 2 commits into
StylianosGakis wants to merge 2 commits into
Conversation
ForeverDeepLinks.kt compiles from commonMain. ForeverEntries.kt stays in androidMain because it uses NavSuiteSceneDecoratorStrategy.showNavBar(), which lives in androidMain of navigation-compose. The metrox ViewModel artifacts were added implicitly to Android library modules and are now declared for androidMain, where metroViewModel() is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI description
Turns
feature-foreverinto a Kotlin Multiplatform module (JVM and Android targets). Part of making the whole app run on a second platform (desktop). Nothing changes on Android.Stacked on #3367 (
forever-ui), which this PR targets.The first commit is pure renames and the second only rewrites the build file. Two things you would not guess:
ForeverEntries.ktstays inandroidMainfor now, because the nav bar scene metadata it uses still lives in the Android source set ofnavigation-compose. It moves once that does.androidMain. The convention plugin only adds them automatically to Android library modules, and this module declares no ViewModels of its own.