Invalidated side fix - #1779
Merged
Merged
Invalidated side fix#1779
Conversation
…ve checks to individual upper/middle/lower functions since parts to fix broken cache invalidation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add counters to side/plane to check if cached data is invalidated.
Move checks to individual upper/middle/lower functions since parts to fix broken cache invalidation.
This was only reproducible by forcing BSP rendering entirely and switching from middle to lower view. The main issue was RenderTwoSided reset the invalidation but the upper/lower visibility may not actually render the side. This means later when rendering the upper/lower the cache was never invalidated and it would pull for the previous transfer heights view.