Fixes from the 5 Oct error review: copy, header names, Odoo grouping, Sentry noise - #885
Merged
Merged
Conversation
…names checked, Odoo grouping, Sentry noise
- Copy buttons go through one copyText() helper with the textarea fallback and
only say "Copied" when it worked. The new API key button said "Copied!"
while the browser refused the write, for a key shown only once
(ANYTHINGMCP-CLOUD-FRONTEND-C).
- Header names are checked as HTTP tokens when a connector is saved and before
a request is sent, with a message that explains Header Name. Two Odoo
connectors had the key's label ("Valentino API Key", "API Odoo") there and
every call failed with Node's "Header name must be a valid HTTP token".
The API-key forms show the rule as you type.
- Odoo (JSON-2): read_group does not exist on Odoo 19; the instructions and
odoo_call_method point to formatted_read_group (13 failed calls in 2 orgs).
- Sentry: ignore raw-body's "request aborted" on the backend
(ANYTHINGMCP-CLOUD-BACKEND-6, 1,388 events from one looping client) and
blocked Google Tag Manager beacons in the cloud app
(ANYTHINGMCP-CLOUD-FRONTEND-D).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a review of Sentry and of
tool_invocationson cloud for the last 48 h.Changes
copyText()(clipboard API, then the textarea fallback thatmcp-server/[id]already had) and only says "Copied" when it worked. The new API key's Copy button said "Copied!" while the browser refused the write (ANYTHINGMCP-CLOUD-FRONTEND-C), and that key is shown only once.ConnectorsService.create/updaterefuse header names that are not HTTP tokens (plain headers,authConfig.headerName,signature.headerName), andRestEnginerefuses them before sending with a message that explains what Header Name is. Two Odoo connectors had the label of their key there ("Valentino API Key", "API Odoo") and every call failed with Node's "Header name must be a valid HTTP token". The API-key fields show the rule as you type. Catalog and production plain headers: none affected (checked).read_groupdoes not exist on Odoo 19 (404, 13 calls in 2 orgs). Instructions andodoo_call_methodnow point toformatted_read_groupwithaggregates.request aborted(client hung up before its body was read; ANYTHINGMCP-CLOUD-BACKEND-6, 1,388 events from one looping client on 4 Oct); the cloud app ignores blocked Google Tag Manager beacons (ANYTHINGMCP-CLOUD-FRONTEND-D).Tests
http-header-name.util.spec.ts, rest.engine case (refused before axios is called); connectors + adapters suites green locally (the HANA suite needshdb, missing in my local install only).sentry-injected-scripts.spec.ts5/5 with the new ignore cases.