Skip to content

Preserve live Railway settings and gate deployments on tested commits - #130

Merged
jackshim415 merged 10 commits into
mainfrom
jackshim415/lvt-336-infrastructure-verify-lovat-railway-iac
Nov 21, 2026
Merged

jackshim415 merged 10 commits into
mainfrom
jackshim415/lvt-336-infrastructure-verify-lovat-railway-iac

Conversation

@jackshim415

@jackshim415 jackshim415 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Keep Railway’s observed source branches, sleeping settings, and preview limits in the named app partial. The latest production dry run proposes only the five source.checkSuites updates. The preview dry run also sets the Worker’s current continuous default explicitly. The production and preview plans reported zero diagnostics. Preview partial ownership and credential isolation still need separate evidence.

Put applicable web-image HTTP smoke tests and CodeQL analysis under the required Monorepo CI status. CodeQL allows a verified empty selection and fails the gate when a selected analysis is missing, fails, or is cancelled. RAILWAY_WAIT_FOR_CI=true renders the provider change for review. The runbook explains how to verify a passing and a failing deployment by commit SHA.

Verification

Refs: LVT-336, LVT-337.

Preserve current staging sources, sleeping policy and inherited preview API limits. Record named-partial adoption, redacted rollback snapshots and empty production/staging/preview plans without applying changes.

Refs: LVT-336
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T06:53:57.368584Z 1173269 PR opened
🔒 Security Review ✅ Completed 2026-11-13T06:55:11.359334Z 1173269 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@railway-app

railway-app Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🚅 Deployed to the lovat-pr-130 environment in lovat

Service Status Web Updated
api ✅ Success (View Logs) Web Nov 21, 2026 at 5:56 am UTC
worker ✅ Success (View Logs) Nov 21, 2026 at 5:56 am UTC
website ✅ Success (View Logs) Web Nov 21, 2026 at 5:56 am UTC
learn 😴 Sleeping (View Logs) Web Nov 21, 2026 at 5:50 am UTC
dashboard 😴 Sleeping (View Logs) Web Nov 13, 2026 at 7:02 am UTC
1 service not affected by this PR
  • support

@railway-app
railway-app Bot temporarily deployed to lovat / lovat-pr-130 November 13, 2026 06:52 Destroyed
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Lovat AI review

Status: completed · Model: z-ai/glm-5.3-flash · Findings: 0

Reviewed commit: 56265a24325a7b4fd8b4e162428f4474e753db5e

Critical: 0 · High: 0 · Medium: 0 · Low: 0

Overall assessment

This batch is mostly CI wiring, Railway IaC test updates, and read-only audit evidence. The CodeQL workflow conversion to workflow_call with an aggregate result gate is internally consistent (skipped analysis passes, failed/cancelled selected analysis fails). The web-images filter mirrors the removed pull_request paths, and the config tests correctly encode the preserved live settings (sleeping on non-worker services, main branch for both environments, env-gated checkSuites). The evidence JSON contains only resource IDs and variable names, no secret values. No concrete defect with an explainable failure mode was found in the changed lines.

This batch aligns the Railway IaC graph with the observed live configuration documented in the evidence files: the staging source branch moves from the stale offseason branch to main, sleeping is declared for the four user-facing apps (worker correctly excluded), and the API container limit now covers previews as well as staging, matching the recorded audit. The CI gate changes (mandatory codeql result, web-images selector) are internally consistent and covered by updated unit tests. The CodeQL matrix change intentionally replaces the workflow force-all with the Actions analysis and is explicitly tested. No concrete defect with an explainable failure mode is present in the changed lines.

No high-confidence issues were found in the reviewed changes.

Review details

  • Review batches: 2
  • Diff characters reviewed: 94,025
  • Tokens: 31,478 prompt + 8,847 completion
  • Estimated inference cost: $0.0042

Limitations

  • The reviewer examined only changed lines and their diff context, not the whole repository.

@github-actions

Copy link
Copy Markdown
Contributor

📱 Connect your app to this PR deployment

Scan a QR code to use this PR's Server API. Worker changes use the same API;
the Worker has no public app endpoint.

Server URL: https://api-lovat-pr-130.up.railway.app

Lovat Collection

QR code — Lovat Collection

lovat-collection://set-url?u=https%3A%2F%2Fapi-lovat-pr-130.up.railway.app

Lovat Dashboard

QR code — Lovat Dashboard

com.frc8033.lovatdashboard:///set-url?u=https%3A%2F%2Fapi-lovat-pr-130.up.railway.app

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11732690a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

| ------------ | -------------------------------------- | --------------------------------------------------------- | --------------------------- | ------------ |
| production | `9f0088a8-9fe7-4afa-b634-cd1db046f045` | `main` | `lovat-apps`, all five apps | No changes |
| staging | `1902828c-65ae-455c-90c8-5a370b7cedab` | `main` | `lovat-apps`, all five apps | No changes |
| lovat-pr-128 | `d42d9835-c01a-48c4-bcd2-424fa61e93c3` | `jackshim415/lvt-334-server-redact-request-analytics-and` | `lovat-apps`, all five apps | No changes |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Mark preview partial ownership as unverified

The preview row still reports that lovat-apps owns all five applications, but preview128-plan-summary.json records an empty ownership object and the following paragraph explicitly says that PR #128 has not been adopted into the partial. This contradictory cutover evidence can lead operators to treat preview ownership as complete, so the table should identify it as unowned or pending adoption.

Useful? React with 👍 / 👎.

…nfrastructure-verify-lovat-railway-iac

# Conflicts:
#	.railway/README.md
#	.railway/config.test.mjs
@railway-app
railway-app Bot temporarily deployed to lovat / lovat-pr-130 November 20, 2026 23:45 Destroyed
github-actions[bot]

This comment was marked as outdated.

Reuse the four SDK 58 patch updates already verified on the Collection native-testing branch.

Refs: LVT-337, LVT-274
@railway-app
railway-app Bot temporarily deployed to lovat / lovat-pr-130 November 20, 2026 23:55 Destroyed
@jackshim415 jackshim415 changed the title fix(infra): preserve verified Railway settings and record cutover evidence Preserve live Railway settings and gate deployments on tested commits Nov 20, 2026
github-actions[bot]

This comment was marked as outdated.

@railway-app
railway-app Bot temporarily deployed to lovat / lovat-pr-130 November 21, 2026 05:42 Destroyed
@railway-app
railway-app Bot temporarily deployed to lovat / lovat-pr-130 November 21, 2026 05:56 Destroyed
@jackshim415
jackshim415 merged commit 2d4c1d5 into main Nov 21, 2026
31 checks passed

This branch was successfully deployed

No deployments
lovat / lovat-pr-130 — 56265a24 Deployed Nov 21, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant