Skip to content

Run the Website production image and CI on Node 24 LTS - #135

Merged
jackshim415 merged 4 commits into
mainfrom
jackshim415/lvt-340-website-upgrade-production-docker
Nov 21, 2026
Merged

jackshim415 merged 4 commits into
mainfrom
jackshim415/lvt-340-website-upgrade-production-docker

Conversation

@jackshim415

@jackshim415 jackshim415 commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Move both Website production image stages to Node 24.21.0 and read the same pin from .nvmrc in CI. The image smoke test now checks the actual Node version inside the running container. The PR also carries the four Collection Expo patch updates already verified on PR #125 to clear the Monorepo CI compatibility gate.

Verification

  • Node 24.21.0: npm run check, npm run lint, npm run build, npm test (53), npm run test:changelog, npm run test:training, bash -n test/image.sh, and all 20 desktop/mobile npm run test:e2e checks passed. Svelte check reports existing warnings.
  • GitHub’s Website image and browser jobs passed, and Railway reported a successful Website preview deployment before the Collection-only follow-up. The exact-head rerun verifies the combined branch.
  • The reused Collection patch set passed expo install --check, TypeScript, lint, formatting, tests, and the existing high-severity audit threshold.

Refs: LVT-340. The Website README covers promotion and rollback.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T23:47:46.373698Z 098bc3c PR opened
🔒 Security Review ✅ Completed 2026-11-20T23:48:06.852879Z 098bc3c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@railway-app

railway-app Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🚅 Deployed to the lovat-pr-135 environment in lovat

Service Status Web Updated
api ✅ Success (View Logs) Web Nov 21, 2026 at 5:33 am UTC
worker ⏭️ Skipped (View Logs) Nov 21, 2026 at 5:31 am UTC
website 😴 Sleeping (View Logs) Web Nov 21, 2026 at 12:04 am UTC
dashboard 😴 Sleeping (View Logs) Web Nov 20, 2026 at 11:57 pm UTC
learn 😴 Sleeping (View Logs) Web Nov 20, 2026 at 11:53 pm UTC
2 services not affected by this PR
  • support
  • worker

@railway-app
railway-app Bot temporarily deployed to lovat / lovat-pr-135 November 20, 2026 23:46 Destroyed
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Lovat AI review

Status: completed · Model: z-ai/glm-5.3-flash · Findings: 0

Reviewed commit: f3e0464bd735a7f902320fe193eaa015a0b03818

Critical: 0 · High: 0 · Medium: 0 · Low: 0

Overall assessment

This pull request is a coordinated Node 24 runtime bump for the Website: .nvmrc, Dockerfile stages, CI jobs, docs, and the image smoke test all move together, and the image test now verifies the actual runtime version inside the container. The Collection dependency bumps are routine patch-level Expo updates. No correctness, security, or contract issues are evident in the changed lines.

No high-confidence issues were found in the reviewed changes.

Review details

  • Review batches: 1
  • Diff characters reviewed: 9,082
  • Tokens: 4,907 prompt + 240 completion
  • Estimated inference cost: $0.0008
  • Files excluded by configuration: 1

Limitations

  • The reviewer examined only changed lines and their diff context, not the whole repository.

Reuse the four SDK 58 patch updates already verified on the Collection native-testing branch.

Refs: LVT-337, LVT-274
@railway-app
railway-app Bot temporarily deployed to lovat / lovat-pr-135 November 21, 2026 05:31 Destroyed
@jackshim415
jackshim415 merged commit 7ae5c69 into main Nov 21, 2026
28 checks passed

This branch was successfully deployed

No deployments
lovat / lovat-pr-135 — f3e0464b Deployed Nov 21, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant