Repository navigation
Restore authenticated account attribution in PostHog - #141
Conversation
Recover account-level support and app-version breakdowns without forwarding team codes, credentials, raw URLs, or payloads. Refs: LVT-334
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
🚅 Deployed to the lovat-pr-141 environment in lovat
1 service not affected by this PR
|
Lovat AI reviewStatus: completed · Model: Reviewed commit: Critical: 0 · High: 0 · Medium: 0 · Low: 0 Overall assessmentThis diff restores authenticated attribution in PostHog telemetry with careful allowlisting: distinct IDs come only from requireAuth-validated JWT/API-key callers, person-profile processing is enabled only in that case, client-supplied hints are strictly pattern-validated, and Collection-style requests remain anonymous. The documentation and tests match the implementation, and no secrets, headers, or identifiers beyond the documented account attributes are captured. No concrete defects were identified in the changed lines. No high-confidence issues were found in the reviewed changes. Review details
Limitations
|
📱 Connect your app to this PR deploymentScan a QR code to use this PR's Server API. Worker changes use the same API; Server URL: |
What changed
Restore stable account attribution for verified Dashboard and API requests in the existing PostHog
responseevent, along with app version, OS, build, and legacy$pathnamereporting. Raw team codes, credentials, URLs, query strings, request/response bodies, names, emails, and IP addresses stay out. Collection requests remain anonymous because shared team access does not prove an individual scouter's identity.Refs: LVT-334, #128.
Areas affected
Contracts and data
Verification
DATABASE_URL=<local unit test URL> npm test(1,457 passed),npm run build,npm run typecheck,npm run typecheck:test, andnpm run lint(no errors; 79 warnings in unchanged files)../scripts/check-structure.shandgit diff --checkpassed.Deployment
No migration, environment variable, or platform configuration changes. PostHog event changes take effect on the next Server deploy.