Codegen: Guzzle 8 Compatibility - #626
Merged
Merged
Conversation
…estore crm/objects - Remove 108 orphaned generated files left behind when APIs were retagged (e.g. Webhooks SubscriptionsApi/SettingsApi → BasicApi/BatchApi; CMS AuditLogs, SiteSearch, UrlRedirects, SourceCode; CRM Associations V4 stale models, etc.) - Guzzle 8 fixes (Utils::jsonEncode, RequestException::getResponse, ConnectException → NetworkException) now propagate to all 156+ generated clients - Restore crm/objects generation from the surviving Custom Objects spec (rollout 424); adds AdvancedApi + two new models (PublicMergeInput, PublicObjectWarning) Generator: HubSpotEngineering/api-clients #376 (Guzzle fixes) + #377 (pruning) Registry: crm/objects entry repointed from retired "Objects" to "Custom Objects" Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
camden11
changed the title
…InFiles The July 2026 "lazy function replacements" change wrapped string replacements in () => replacement, which prevents JavaScript's $1 capture group expansion. This caused json_encode($1, ...) to appear literally in generated PHP, breaking all clients. Pass string replacements directly to String.replace() so $1 expands. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… classes Repoints 25 Discovery classes and their PHPSpec tests to match the API class renames and removals from the codegen regen (orphan pruning + Custom Objects registry fix). Old names like CardsApi, CoreApi, SettingsApi, etc. are replaced with BasicApi/AdvancedApi/BatchApi per the new generator output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Cms/Hubdb: remove deleted RowsBatchApi - Cms/Pages: remove deleted SitePagesApi, add 7 new APIs from regen - Crm/Lists: replace 5 deleted APIs with BasicApi/BatchApi/SearchApi - Marketing/Emails: remove deleted StatisticsApi, add BasicApi Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
DiscoveryBase::__call resolves via ucfirst(), so abTestsApi() becomes AbTestsApi, which doesn't match the actual class ABTestsApi. Add an explicit method to bypass __call for this one accessor. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
camden11
marked this pull request as ready for review
September 23, 2026 18:39
ashleighliu
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.