Repository navigation
Find workspace packages from both pnpm-workspace.yaml and package.json - #31
Merged
Merged
Conversation
pnpm reads only pnpm-workspace.yaml, and npm, Yarn and Bun only the workspaces of package.json, so a repository that moved to pnpm may keep an old list. Packages listed only in pnpm-workspace.yaml were not found when package.json had a list too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
trigger.dev keeps an old
workspaceslist inpackage.jsonnext to itspnpm-workspace.yaml, and the scan read only the old list, so@internal/testcontainerswas reported as "not a local file, a path alias or a workspace package". pnpm reads onlypnpm-workspace.yaml, and npm, Yarn and Bun onlypackage.json, so packages from both lists are found now.No change on the corpus.
Checklist
npm run coveragereports 100%.npm run changeset), or the change does not affect them.