Skip to content

Find workspace packages from both pnpm-workspace.yaml and package.json - #31

Merged
Huldoser merged 1 commit into
mainfrom
pnpm-and-npm-workspaces
Oct 14, 2026
Merged

Huldoser merged 1 commit into
mainfrom
pnpm-and-npm-workspaces

Conversation

@Huldoser

Copy link
Copy Markdown
Owner

What changed

trigger.dev keeps an old workspaces list in package.json next to its pnpm-workspace.yaml, and the scan read only the old list, so @internal/testcontainers was reported as "not a local file, a path alias or a workspace package". pnpm reads only pnpm-workspace.yaml, and npm, Yarn and Bun only package.json, so packages from both lists are found now.

No change on the corpus.

Checklist

  • Tests cover the change, and npm run coverage reports 100%.
  • The docs describe the change: the guide or reference pages, the README, or the TSDoc of exported functions.
  • No docs change is needed.
  • A changeset describes the change for users (npm run changeset), or the change does not affect them.

pnpm reads only pnpm-workspace.yaml, and npm, Yarn and Bun only the workspaces of package.json, so a repository that moved to pnpm may keep an old list. Packages listed only in pnpm-workspace.yaml were not found when package.json had a list too.
@Huldoser
Huldoser enabled auto-merge (squash) October 14, 2026 14:55
@Huldoser
Huldoser merged commit 631cc6b into main Oct 14, 2026
27 checks passed
@Huldoser
Huldoser deleted the pnpm-and-npm-workspaces branch October 14, 2026 14:59
@Huldoser Huldoser mentioned this pull request Oct 14, 2026
2 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant