Repository navigation
Match test files in folders whose names start with a dot - #32
Merged
Merged
Conversation
Playwright and Vitest both find test files under folders such as .storybook/ or .github/scripts/, which the glob left out. .git folders are left out, like node_modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Playwright and Vitest both find test files under folders whose names start with a dot, such as
.storybook/or.github/scripts/; the scan's glob left them out. In the comparison with Vitest on 40 open-source projects, Mermaid, n8n, Lobe Chat and Element Plus have tests there. Globs now match such names, and.gitfolders are left out likenode_modules.No change on the corpus, whose patterns don't reach dot folders.
Checklist
npm run coveragereports 100%.npm run changeset), or the change does not affect them.