fixes to shef exporter - #76
Merged
Enovotny merged 4 commits intoJun 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes for issue #73, #74, #75 plus
related robustness improvements to the CDA exporter/loader and the export CLI.
Changes
CDA exporter (shef/exporters/cda_exporter.py)
no values in the window — log and continue instead of aborting the whole
export.
[...] with comma bookkeeping.
when exporting a group.
CDA loader (shef/loaders/cda_loader.py)
can be fetched instead of all SHEF Export groups. Tracks loaded groups to
avoid redundant CDA calls.
with a warning instead of producing an empty SHEF file.
Export CLI (shef/shef_parser.py)
supporting ISO 8601 and HEC-style relative times (T, T-1D, T+2H, …).
unparseable input.
changes).
Optional dependencies (pyproject.toml, dss_loader.py, abstract_exporter.py)
missing.
Tests
Three new test files:
succeeds when some series in a group are empty or error.
loading, alias-id skipping, and caching.
the export CLI.
Test plan
tests/test_cda_loader_make_export_transforms.py
tests/test_export_time_window.py
an empty-alias entry and verify the output SHEF file is non-empty.
hecdss/cwms installed.