build: migrate releases to Release Please - #80
Open
krowvin wants to merge 7 commits into
Open
Conversation
Author
|
@Enovotny here's a followup from our earlier discussion. When you have a moment could you review this Release Please migration? It follows cwms-cli, with separate commits for removal, version configuration, publishing CI, title reminders, and docs. I'm not a maintainer and cannot set you as a reviewer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces manually tagged releases and automatic TestPyPI uploads with the Release Please flow used by cwms-cli. Merging normal changes into master prepares a version/changelog PR; merging that PR creates the tag and GitHub release, tests and builds that exact tag, publishes to PyPI, and uploads signed distributions.
The advisory title reminder supports scopes and breaking changes, corrects the copyable examples from cwms-cli, and updates/removes only its own bot comment. New CONTRIBUTING.md guidance, linked from README, covers development, release titles, TestPyPI retirement, setup, and recovery. This PR comes from krowvin/fork-SHEF_processing because I have read-only upstream access.
Validation:
shefParser --versionpassed. Poetry reports existing legacy metadata deprecation warnings.tests/test_cli_export_cda_errors.py::test_export_cda_missing_required_argsfailed on Windows/Python 3.13. It expects --office to be required, but the CLI proceeds to http://x and receives an ApiError. Reproduced the same failure on an untouched upstream/master worktree using the same environment. No test or application source was changed by this PR; the new publication test gate will expose this failure if it also occurs on the release runner.Maintainer setup: retain the existing PyPI trusted publisher for
pypi-deploy.yml/ environmentrelease, allow default-branch deployments if the environment restricts branches, and allow Actions to create PRs. The docs explain how to trigger missing release-PR checks when using GITHUB_TOKEN. The new release workflow and title reminder require merging before they can be exercised on the default branch.