Conversation
krowvin
left a comment
There was a problem hiding this comment.
A lot of acronyms. I'm not familiar with pixml. Might consider spelling the first ones out or linking to external docs more too.
Commenting for now, give Eric some time to peak this if he can.
There was a problem hiding this comment.
The only thing I really want to confirm before approval is our use of options, flags, and sub commands.
Typically something like
-i is a short option
--input is a long option
cwms-cli nws is a sub command of cwms-cli
In the source it is reading like
cwms-cli nws input ...etc is a valid option/arg.
I'd say the rest is largely up to you to decide if you wish to make changes, just let me know your thoughts in the replies.
That and if Mike has any opinions on that massively negative number. To me that looks like it's a 128bit signed number. Suggesting if you go to the bottom max of a 128bit signed value that's pretty much zero?
| logger = logging.getLogger(__name__) | ||
|
|
||
| # CWMS sentinel for a missing value and its quality code. | ||
| CWMS_MISSING_VALUE = -340282346638528859811704183484516925440 |
There was a problem hiding this comment.
I think this is the java max float, right Mike. Probably would be best to have this in cwms-python or have CDA support?
…normal run, and are reported under not_in_timeseries_group during a dry run.
Use
cwms-cli nws pixmlto load an NWS/RFC Delft-FEWS PI-XML forecast product into a CWMS database. Parameter mapping, timeseries group overrides, versioning, and issued-time tracking is driven by a JSON config file or a config blob stored in CDA.nws pixmlsupports:.gz/.zipauto-unzipped)This was based on MVP and MVM's needs and tested on the MVP and MVM RFC products with the hope that it may be configurable for other district's needs.
Developed with Claude Opus.