Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .agents/skills/code-review/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ You MUST adhere to this form because it will be later used by automation to crea

If the rule asks for a citation, put it in the `description` field.

To fetch the full diff use
```shell
git fetch origin && git diff origin/master...HEAD
```

Below are rules you should check when reviewing the code.

### duplicate-code
Expand Down Expand Up @@ -123,3 +128,7 @@ subprocess/os.system/os.popen runs a shell with concatenated or formatted user/e
### pointless-wrapper

A new or changed function or method only forwards to another callable with the same arguments and return value, adding no conversion, validation, defaulting, error handling, or other logic. Only flag when call sites could invoke the inner callable directly, the wrapper does not implement an interface, protocol, or abstract method, and it is not a public re-export of a private or third-party symbol.

### redundant-parameter

All callers of a new or changed function, method or class pass the same value for the parameter such that a parameter can be deleted without affecting any behaviour of all callers.
2 changes: 1 addition & 1 deletion .template.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Autogenerated - DO NOT EDIT
# Parameters of the project as generated from template
_commit: fcdbd3c
_commit: c1e44de
_src_path: gh:kraysent/python-template
package_name: uploader
project_name: uploader
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,4 @@ from collections.abc import Sequence

### File changes

When moving files as part of a refactor of any kind prefer using `git mv` whenver possible instead of removing + adding.
When moving files as part of a refactor of any kind prefer using `git mv` whenever possible instead of removing + adding.
3 changes: 1 addition & 2 deletions uploader/task_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ def register_all_tasks() -> None:
id="upload-structured-designation",
title="Upload designations",
description=(
"Evaluate a designation expression per row and upload names. "
"Normalization is done by the backend."
"Evaluate a designation expression per row and upload names. Normalization is done by the backend."
),
additional_description=expression_syntax_help(),
form_model=StructuredDesignationForm,
Expand Down
Loading