Make documented build targets work - #19
Open
aleksUIX wants to merge 2 commits into
Open
Conversation
A fresh clone could not follow the README: make deps/generate/docker-build/health-check did not exist, make bindings looked for a repo-root openrtb.proto, rust/cargo.toml was not a Cargo.toml, and Docker HEALTHCHECK called a flag the binary did not implement. Closes IABTechLab#17.
Do not no-op bindings/check/docs or rewrite the spec getting-started block. The Go agent still builds from checked-in pkg/pb/ without protoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17. A fresh clone could not follow the documented agent build, and
make build-rustfailed becauserust/cargo.tomlis not aCargo.toml.This keeps the spec Makefile and the spec README getting-started block. It does not no-op
bindings/check/docs. Proto regen remains #11 / PR #18, which already rewiresbindingstoscripts/generate.sh.deps,generate->scripts/generate.sh,docker-build,health-check,run-devas an alias ofrun-all, coverage, samples).make builduses checked-inpkg/pb/; protoc is not required to build the agent.rust/cargo.tomltorust/Cargo.tomlsomake build-rustworks.-health-checkas a one-shot probe of/health/ready, and point Docker / compose HEALTHCHECK at that binary. The image has nowget/curl. Spec agent-manifest probes stay HTTP GET/health/liveand/health/ready..dockerignoresodocker builddoes not sendrust/target.Test plan
make deps && make build && make test && make lintmake generateinvokesscripts/generate.sh(fails without plugins / until Fix proto/generated-code drift breaking gRPC reflection and samples #18; not required to build)./artf-agent -health-checkexits 1 with no server, 0 against a running agentmake health-checkcurls/health/liveand/health/readymake build-rustproducesrust/target/release/agentic-rtb-framework-servicedocker buildthendocker runreportsHealth: healthyvia-health-check(no wget)