Conversation
Delete the archived publisher IDs audit. It catalogued hardcoded values in gam.rs and prebid.rs; gam.rs no longer exists and the segment string is gone from crates/, so the cleanup it tracked is complete and the only remaining content is the identifiers themselves. Replace the ad server network ID in the PR #680 plan's example config with a fictional value, matching the instruction in that same step to use only example values.
jevansnyc
changed the title
prk-Jr
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two stale planning docs on
mainstill carried publisher-specific ad identifiers. Both describe work that has since shipped.Changes
certain parameters that are available in the browser, but could be considered sensitive have been removed.
Scope
Docs only, no code or config touched. These values remain in git history (they trace back to the initial commit), so this is not a purge. It removes them from the working tree, code search, and secret scanning.
Verification
git grepfor each identifier returns clean across the tree