Repository navigation
fixrule(a_target_warning): check accessible name for the new window hint - #2658
Merged
tombrunet merged 3 commits intoOct 16, 2026
Merged
Conversation
The new window hint was missed when it was in aria-label, a child img alt or an svg title. Also match case insensitively. The area elements in TargetText-valid.html pass now since their alt says "in new window". Fixes IBMa#1951 Signed-off-by: rmz-oz <262968088+rmz-oz@users.noreply.github.com>
Contributor
Author
|
I agree to the DCO at https://developercertificate.org/ for this contribution. |
tombrunet
requested changes
Sep 30, 2026
Member
There was a problem hiding this comment.
Suggested change
| num: "2.4.4", |
We had some discussion and I think this more correctly maps to 2.4.4, which would better fit with your changes since it allows for programmatic name. 3.2.2 is more about inputs rather than links. G201 aligns with this recommendation. We should fix the references in the related help file also.
Contributor
Author
There was a problem hiding this comment.
Switched it to 2.4.4 and changed the help page link to IBM 2.4.4 Link Purpose (in Context).
Signed-off-by: rmz-oz <262968088+rmz-oz@users.noreply.github.com>
tombrunet
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The rule now also looks at the link's accessible name and the alt or title of its content, case insensitive. The area elements in TargetText-valid.html have "in new window" in their alt, so they pass now and I took them out of failedXpaths.
This PR is related to the following issue(s):
Testing reference:
I have conducted the following for this PR:
I agree to the DCO at https://developercertificate.org/ for this contribution.as a comment after creating the pull request.Assets to aide review attached
Definition of Done