Repository navigation
fix(engine): Preserve presentational image semantics when resolving roles - #2661
Draft
mugiwarafx wants to merge 1 commit into
Draft
mugiwarafx wants to merge 1 commit into
mugiwarafx wants to merge 1 commit into
Conversation
…oles Signed-off-by: mugiwarafx <sangalesbenes@uoc.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An image with a non-empty
altandrole="presentation"currently contributes a name to its containing heading becausegetResolvedRolefilters explicit roles through the host element's author-conformance allowlist. Both heading checks therefore pass ACT ffd0e9 Failed Example 4, which expects failure:Resolve the first supported explicit role independently of author validation, retaining presentational-role conflict handling for focusability (including negative
tabindex) and global ARIA attributes.getInvalidRolescontinues to validate author conformance against the existing tables. Explicit-only lookups use a separate cache entry to prevent implicit-role results from leaking between lookup modes.This shared-resolver change also restores two missing-parent failures in an existing fixture (
treeitemandmenuitemroles on disallowed hosts). Regression tests cover the heading example, role precedence, focus/global-attribute exceptions, and cache order. The draft leaves ACT mapping and the remaining ffd0e9 discrepancies for follow-up, and requests review of the resolver behavior in the context of #2629's IBM guidance alignment requirement.This PR is related to the following issue(s):
Testing reference:
npm run build-debug: passed.npm test: 1,641 passed (1,619 existing tests plus 22 new regression tests).npm run test:sr -- --port 9878: 332 passed.git diff --check: passed. Local validation used Node v24.16.0 and Chrome 155 on macOS.I have conducted the following for this PR:
I agree to the DCO at https://developercertificate.org/ for this contribution.as a comment after creating the pull request.Assets to aide review attached
Definition of Done