UI: Improve Displaying of Duration in Filter - #12047
Open
kergomard wants to merge 1 commit into
Open
Conversation
Contributor
|
I added the other authorities for informational purposes. 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, this is a very small improvement and just straightens the display of the duration-input in filters. It also changes the language variable to use an upper case, as the places this will be used require a title case as far as I can see. The unrelated change in the language file just concerns a trailing space that was automatically cleaned.
I do not fix the issue that only pressing "Enter/Return" (or clicking outside of the popup) will close it and set the values. This is, as far as I can see, expected behavior and any way it would be part of a bigger issue, as e.g. the multiselect-inputs can not be entered at all via keyboard (at least I didn't find a way).
See: https://mantis.ilias.de/view.php?id=43967
Before:

After:

Best,
@kergomard