Repository navigation
Fix SPICE CLI query date filters - #365
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes address the reported issue, preserve existing mappings, and have no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes #364 by translating CLI date filters into the parameter names expected by /spice-query.
Changes:
- Maps
start_dateandend_datetostart_timeandend_time. - Preserves ingestion-date mappings and updates test expectations.
| File | Description |
|---|---|
| tests/test_io.py | Updates expected SPICE query parameter mappings. |
| imap_data_access/io.py | Extends date-filter translation using a shared mapping loop. |
Review effort: Balanced
leowerneck
merged commit Oct 20, 2026
4d85f60
into
IMAP-Science-Operations-Center:main
15 of 16 checks passed
leowerneck
deleted the
364-bug---spice-cli-queries-don-t-accept-date-filters
branch
October 20, 2026 15:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Closes #364.
Overview
This fix extends the current translation between CLI date arguments and the ones expected by
/spice-queryto also support--start-dateand--end-date, translating them tostart_timeandend_time, respectively.File changes
imap_data_access/io.py: extended existing logic to support multiple parameters in a cleaner way.tests/test_io.py: mimic the logic inimap_data_access/io.py, as before.Testing
Running
results in 150 tests passing, no failures.