Repository navigation
[pre-commit.ci] pre-commit autoupdate - #225
pre-commit-ci[bot] wants to merge 1 commit into
Conversation
|
This PR not only updates the pre-commit, but also runs ruff with fixes across the entire repo. Something about that is actually breaking the code, so this needs to be done after bringing everything up to snuff formatting-wise. Kicking that can, but leaving the PR open so we don't lose lock (unlikely to ever be merged as such, though). |
|
I changed it to draft so it doesn't look like something we need to review constantly. As you said, it won't be merged in the current form anyway, so draft seems more appropriate. |
|
Many, but not all, of the test failures here also materialized in #241 (and are fixed there). |
|
A lot of the remaining test failures are from UP405 substitutions like: - sp: Optional[np.array] = None,
- flags: Optional[np.array] = None,
+ sp: np.array | None = None,
+ flags: np.array | None = None,leading to TypeError: unsupported operand type(s) for |: 'builtin_function_or_method' and 'NoneType'I think the problem is that the type is |
|
Is it possible to restart this PR from the latest main? I'm not sure rebasing/merging would be easy at this point, but the diff is also much larger than it needs to be. |
dca55e6 to
839c1fa
Compare
|
I reset it to the latest |
|
Superseded by #246 |
updates: