Skip to content

[pre-commit.ci] pre-commit autoupdate - #225

Closed
pre-commit-ci[bot] wants to merge 1 commit into
mainfrom
pre-commit-ci-update-config
Closed

pre-commit-ci[bot] wants to merge 1 commit into
mainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci

@pre-commit-ci pre-commit-ci Bot commented Oct 5, 2026

Copy link
Copy Markdown

@jtniehof

jtniehof commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

This PR not only updates the pre-commit, but also runs ruff with fixes across the entire repo. Something about that is actually breaking the code, so this needs to be done after bringing everything up to snuff formatting-wise. Kicking that can, but leaving the PR open so we don't lose lock (unlikely to ever be merged as such, though).

@leowerneck
leowerneck marked this pull request as draft October 8, 2026 15:54
@leowerneck

leowerneck commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

I changed it to draft so it doesn't look like something we need to review constantly. As you said, it won't be merged in the current form anyway, so draft seems more appropriate.

@jtniehof

Copy link
Copy Markdown
Collaborator

Many, but not all, of the test failures here also materialized in #241 (and are fixed there).

@jtniehof

jtniehof commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

A lot of the remaining test failures are from UP405 substitutions like:

-    sp: Optional[np.array] = None,
-    flags: Optional[np.array] = None,
+    sp: np.array | None = None,
+    flags: np.array | None = None,

leading to

TypeError: unsupported operand type(s) for |: 'builtin_function_or_method' and 'NoneType'

I think the problem is that the type is np.array, which is a factory, and the actual type is ndarray.

@leowerneck

leowerneck commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Is it possible to restart this PR from the latest main? I'm not sure rebasing/merging would be easy at this point, but the diff is also much larger than it needs to be.

@leowerneck
leowerneck force-pushed the pre-commit-ci-update-config branch from dca55e6 to 839c1fa Compare October 27, 2026 19:36
@leowerneck

Copy link
Copy Markdown
Collaborator

I reset it to the latest main and bumped the version of the pre-commit hook. This should hopefully make it easier to debug.

@jtniehof

Copy link
Copy Markdown
Collaborator

Superseded by #246

@jtniehof jtniehof closed this Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants