Repository navigation
Skip IDEX L2A fits for saturated waveforms - #3589
Merged
lacoak21 merged 3 commits intoNov 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the saturation-aware waveform fitting changes.
No open issues 🎉
What changed in this PR
This PR updates IDEX L2A processing to skip fits for saturated waveforms while preserving events and independently processing unsaturated channels.
Changes:
- Bypass TOF High peak fitting and return NaN fit products for saturated Target and Ion Grid waveforms.
- Add tests for mixed, fully saturated, and unsaturated inputs, including optimizer skipping, channel independence, and CDF output.
| File | Description |
|---|---|
imap_processing/tests/idex/test_idex_l2a.py |
Tests saturation-aware fitting, unchanged inputs, and missing saturated fit products. |
imap_processing/idex/idex_l2a.py |
Applies per-channel saturation flags before fitting and documents skipped-fit behavior. |
Review effort: Balanced
Contributor
|
can you write an issue and link it to this PR? Same with your other PRs. We use issues to track work during monthly meetings and its good to have visibility for these PRs there. |
lacoak21
approved these changes
Nov 5, 2026
Contributor
|
@aldo9253 issue is still not linked above. Seems like there is also an unaddressed comment |
Contributor
|
Also can you resolve the merge conflicts? |
Contributor
Collaborator
Author
|
Okay, should be good now! Let me know if I missed something. |
lacoak21
merged commit Nov 10, 2026
c9297ef
into
IMAP-Science-Operations-Center:dev
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
closes #3628
Overview
Skip fitting saturated TOF High, Target, and Ion Grid waveforms, preserving unsaturated channels within each event.
File changes
idex_l2a.py: apply saturation flags before fitting and return missing fit products for saturated waveforms.test_idex_l2a.py: verify skipped fits and independent channel processing.Testing
119 IDEX tests passed, Local CDF validation confirmed saturated fits were removed and retained fits were unchanged.